🤖 Merge PR DefinitelyTyped#69140 [react] Remove Readonly<P> from class component constructor by @eps1lon

Author: eps1lon

types/react/index.d.ts

@@ -995,7 +995,7 @@ declare namespace React {
          */
         context: unknown;
 
-        constructor(props: Readonly<P> | P);
+        constructor(props: P);
         /**
          * @deprecated
          * @see {@link https://legacy.reactjs.org/docs/legacy-context.html React Docs}

types/react/test/index.ts

@@ -82,6 +82,14 @@ declare const container: Element;
         }
     }
     class BetterPropsAndStateChecksComponent extends React.Component<Props, State, Snapshot> {
+        constructor(props: Props) {
+            super(props);
+            // This should ideally error since `props` should not be mutated, but it doesn't.
+            props.foo = 2;
+            // @ts-expect-error
+            this.props = { type: "foo" };
+        }
+
         render() {
             return null;
         }
@@ -117,6 +125,13 @@ declare const container: Element;
             };
         }
     }
+
+    class InferredConstructorProps extends React.Component<{ value: string }> {
+        // @ts-expect-error ts(7006) Ideally, this would infer the props type from the type parameter but has implicit any.
+        constructor(props) {
+            super(props);
+        }
+    }
 }
 
 class ModernComponent extends React.Component<Props, State, Snapshot>

types/react/ts5.0/index.d.ts

@@ -996,7 +996,7 @@ declare namespace React {
          */
         context: unknown;
 
-        constructor(props: Readonly<P> | P);
+        constructor(props: P);
         /**
          * @deprecated
          * @see {@link https://legacy.reactjs.org/docs/legacy-context.html React Docs}

types/react/ts5.0/test/index.ts

@@ -82,6 +82,14 @@ declare const container: Element;
         }
     }
     class BetterPropsAndStateChecksComponent extends React.Component<Props, State, Snapshot> {
+        constructor(props: Props) {
+            super(props);
+            // This should ideally error since `props` should not be mutated, but it doesn't.
+            props.foo = 2;
+            // @ts-expect-error
+            this.props = { type: "foo" };
+        }
+
         render() {
             return null;
         }
@@ -117,6 +125,13 @@ declare const container: Element;
             };
         }
     }
+
+    class InferredConstructorProps extends React.Component<{ value: string }> {
+        // @ts-expect-error ts(7006) Ideally, this would infer the props type from the type parameter but has implicit any.
+        constructor(props) {
+            super(props);
+        }
+    }
 }
 
 class ModernComponent extends React.Component<Props, State, Snapshot>