Camo Everything #96
Merged
Camo Everything #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 looks good to me. I'll merge and cut a new release unless someone has more feedback. |
|
(noting that I don't have commit access to merge myself) |
|
@josh added as a collaborator! |
|
Haha, I didn't need commit, but thanks. I'll let you manage the release. |
ghost
mentioned this pull request
Repository owner
deleted a comment from
loganscabbyface
Oct 12, 2020
|
|
|
|
Repository owner
locked as spam and limited conversation to collaborators
Nov 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Camo's all images including
https.Removed
http/https://github.comimage rewriting. Those shouldn't but linked to in GFM. So no one ought to be doing that. They should be using github helpers so they point to our CDN. Also, this would point them to a CDN through camo. Fewer edge cases./cc @jch @atmos