Skip to content

fix(segment-view): prevent vertical scroll while scrolling horizontally #30276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 2, 2025

Conversation

thetaPC
Copy link
Contributor

@thetaPC thetaPC commented Mar 19, 2025

Issue number: resolves #30001


What is the current behavior?

When segment view has content that is long enough to render outside of the viewport, then a user can scroll vertically and horizontally when the user scrolled down to see the content at the bottom. This causes disorientation as scrolling should only be in one direction.

This only happens on a mobile device, specifically Android. It can be reproduce with a browser simulator.

What is the new behavior?

  • Updated styling to take into account that content might be outside of the viewport.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Dev build: 8.5.2-dev.11743531350.19e040aa

Copy link

vercel bot commented Mar 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 1, 2025 6:16pm

@thetaPC thetaPC marked this pull request as ready for review March 26, 2025 20:41
@thetaPC thetaPC requested a review from a team as a code owner March 26, 2025 20:41
Copy link
Member

@ShaneK ShaneK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@thetaPC thetaPC added this pull request to the merge queue Apr 2, 2025
Merged via the queue into main with commit 105796f Apr 2, 2025
61 checks passed
@thetaPC thetaPC deleted the FW-6259 branch April 2, 2025 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Swipeable Segments - vertical scrolling should be disabled
3 participants