perf(sheet): fixing performance regression on modal sheets when expandToScroll is false #30267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…ToScroll is false
2 tasks
aeharding
reviewed
Mar 18, 2025
…c when expandToScroll is diabled
brandyscarney
changed the title
|
I created a dev build for device testing: |
brandyscarney
approved these changes
Mar 19, 2025
thetaPC
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
Currently, when a sheet is moved while
expandToScrollis disabled, the DOM is queried excessively causing performance degradation.What is the new behavior?
We now cache the targeted element in
onStartand refer to it inonMoveandonEnd, preventing over-querying the DOMDoes this introduce a breaking change?
Other information
This regression was introduced in #30257 and quickly highlighted by a member of the community