Skip to content

Commit 05913c3

Browse files
authored
fix(angular): add focusTrap prop to modal and popover (#29729)
Issue number: resolves #29728 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> The `focusTrap` property was missed when adding focus trapping configuration to the modal and popover. This results in a type error when developers attempt to assign to the property. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Adds `focusTrap` property to `ion-modal` and `ion-popover` for the angular component wrappers - Resolves type warnings when using the property in angular ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Dev-build: `8.2.6-dev.11721672792.195afb09`
1 parent e344f7d commit 05913c3

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

packages/angular/common/src/overlays/modal.ts

+1
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,7 @@ const MODAL_INPUTS = [
6060
'cssClass',
6161
'enterAnimation',
6262
'event',
63+
'focusTrap',
6364
'handle',
6465
'handleBehavior',
6566
'initialBreakpoint',

packages/angular/common/src/overlays/popover.ts

+1
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ const POPOVER_INPUTS = [
5656
'dismissOnSelect',
5757
'enterAnimation',
5858
'event',
59+
'focusTrap',
5960
'isOpen',
6061
'keyboardClose',
6162
'leaveAnimation',

0 commit comments

Comments
 (0)