Made unrecoverable evaluation errors immediately terminate a message rather than force re-send

Author: manterfield

internal/hops/runner.go

@@ -92,14 +92,14 @@ func (r *Runner) SequenceCallback(
 	ons, d := automations.EventOns(msgBundle)
 	if d.HasErrors() {
 		r.logDiagnostics(d, logger)
-		return false, fmt.Errorf("Error evaluating automations: %s", d.Error())
+		return false, fmt.Errorf("%w: %s", nats.ErrEventFatal, d.Error())
 	}
 
 	if len(ons) == 0 {
 		return false, nil
 	}
 
-	logger.Debug().Msg("Successfully evaluated event's automations")
+	logger.Debug().Msg("Successfully evaluated automations")
 
 	var mergedErrors error
 	// NOTE: We could potentially get a speed boost by dispatching/handling each

nats/client.go

@@ -34,6 +34,7 @@ const (
 )
 
 var (
+	ErrEventFatal          = errors.New("This event cannot be processed")
 	ErrIncompleteMsgBundle = errors.New("Unable to fetch complete sequence history")
 	nameReplacer           = strings.NewReplacer("*", "all", ".", "dot", ">", "children")
 )
@@ -192,6 +193,10 @@ func (c *Client) ConsumeSequences(ctx context.Context, fromConsumer string, hand
 			}
 
 			handled, err := handler.SequenceCallback(ctx, hopsMsg.SequenceId, msgBundle)
+			if errors.Is(err, ErrEventFatal) {
+				msg.Term()
+				return
+			}
 			if err != nil {
 				msg.NakWithDelay(3 * time.Second)
 				return