From 12db283f7b7e9c2057d67d0f620da8ac59f88584 Mon Sep 17 00:00:00 2001 From: Javier Neira Date: Fri, 3 Dec 2021 09:54:00 +0100 Subject: [PATCH 1/2] Enable outer/inner hover signature To check the status of #767 --- ghcide/test/exe/Main.hs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ghcide/test/exe/Main.hs b/ghcide/test/exe/Main.hs index 337ccb80dd..ff2e02562f 100644 --- a/ghcide/test/exe/Main.hs +++ b/ghcide/test/exe/Main.hs @@ -4008,8 +4008,8 @@ findDefinitionAndHoverTests = let test no yes docL41 constr "type constraint in hover info #1012" else test no broken docL41 constr "type constraint in hover info #1012" - , test broken broken outL45 outSig "top-level signature #767" - , test broken broken innL48 innSig "inner signature #767" + , test no yes outL45 outSig "top-level signature #767" + , test no yes innL48 innSig "inner signature #767" , test no yes holeL60 hleInfo "hole without internal name #831" , test no skip cccL17 docLink "Haddock html links" , testM yes yes imported importedSig "Imported symbol" From df132d0747e7a230a40ff0af8b0954c58f9594d8 Mon Sep 17 00:00:00 2001 From: Javier Neira Date: Fri, 3 Dec 2021 13:11:34 +0100 Subject: [PATCH 2/2] Change position for top-level signature And mark as broken inner one --- ghcide/test/exe/Main.hs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ghcide/test/exe/Main.hs b/ghcide/test/exe/Main.hs index ff2e02562f..1eb0e9dd00 100644 --- a/ghcide/test/exe/Main.hs +++ b/ghcide/test/exe/Main.hs @@ -3954,7 +3954,7 @@ findDefinitionAndHoverTests = let chrL36 = Position 41 24 ; litC = [ExpectHoverText ["'f'"]] txtL8 = Position 12 14 ; litT = [ExpectHoverText ["\"dfgy\""]] lstL43 = Position 47 12 ; litL = [ExpectHoverText ["[8391 :: Int, 6268]"]] - outL45 = Position 49 3 ; outSig = [ExpectHoverText ["outer", "Bool"], mkR 46 0 46 5] + outL45 = Position 49 3 ; outSig = [ExpectHoverText ["outer", "Bool"], mkR 50 0 50 5] innL48 = Position 52 5 ; innSig = [ExpectHoverText ["inner", "Char"], mkR 49 2 49 7] holeL60 = Position 62 7 ; hleInfo = [ExpectHoverText ["_ ::"]] cccL17 = Position 17 16 ; docLink = [ExpectHoverText ["[Documentation](file:///"]] @@ -4009,7 +4009,7 @@ findDefinitionAndHoverTests = let else test no broken docL41 constr "type constraint in hover info #1012" , test no yes outL45 outSig "top-level signature #767" - , test no yes innL48 innSig "inner signature #767" + , test broken broken innL48 innSig "inner signature #767" , test no yes holeL60 hleInfo "hole without internal name #831" , test no skip cccL17 docLink "Haddock html links" , testM yes yes imported importedSig "Imported symbol"