Add language extension code action targets the nearest {-# pragma

[isovector]

Given this:

data Metaprogram = Metaprogram
  { mp_name             :: !Text
  , mp_known_by_auto    :: !Bool
  , mp_show_code_action :: !Bool
  , mp_program          :: !(TacticsM ())
  }
  deriving stock Generic
{-# ANN Metaprogram "hello" #-}

instance NFData Metaprogram where
  rnf (!(Metaprogram !_ !_ !_ !_)) = ()

without -XBangPatterns enabled, I get a code action on the last line, suggesting I add BangPatterns. Doing so produces this output:

data Metaprogram = Metaprogram
  { mp_name             :: !Text
  , mp_known_by_auto    :: !Bool
  , mp_show_code_action :: !Bool
  , mp_program          :: !(TacticsM ())
  }
  deriving stock Generic
{-# ANN Metaprogram "hello" #-}
{-# LANGUAGE BangPatterns #-}

instance NFData Metaprogram where
  rnf (!(Metaprogram !_ !_ !_ !_)) = ()

which is super the wrong place for it.

[isovector]

Also happens with INLINE pragmas

[Ailrun]

haskell-language-server/plugins/hls-pragmas-plugin/src/Ide/Plugin/Pragmas.hs

Line 192 in d4e2a6f

line = maybe 0 succ (lastLineWithPrefix "{-#" <|> lastLineWithPrefix "#!")

is the line causing the problem.

[jneira]

pragmas plugin is having a hard time finding the correct place to add the extension 😄
we must add a regression test for this (and over whatever corner case we can think of!)

[jneira]

This was closed by #2043 i suppose, closing optimistically