Skip to content

Honour or remove "maxNumberOfProblems" configuration option #1534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lukel97 opened this issue Jun 18, 2020 · 3 comments · Fixed by #1567
Closed

Honour or remove "maxNumberOfProblems" configuration option #1534

lukel97 opened this issue Jun 18, 2020 · 3 comments · Fixed by #1567
Labels

Comments

@lukel97
Copy link
Collaborator

lukel97 commented Jun 18, 2020

As I was looking through the VS Code extensions API documentation, I found that the maxNumberOfProblems configuration option is lifted straight from the example extension that they provide. It looks like it may have been accidentally leftover when setting up the boilerplate

I'm not sure how useful such a configuration option is in practice, and does haskell-language-server/ghcide still support this?

@alanz
Copy link
Collaborator

alanz commented Jun 18, 2020

I am pretty sure it used to, in hie.

@jneira
Copy link
Member

jneira commented Mar 9, 2021

From a quick search in the hls repo, it seems it is not being used at all so we should either honour it or remove it from here and the vscode extension configuration

@jneira jneira transferred this issue from haskell/vscode-haskell Mar 9, 2021
@jneira jneira changed the title Remove "maxNumberOfProblems" configuration option Honour or remove "maxNumberOfProblems" configuration option Mar 9, 2021
@jneira jneira added component: ghcide type: enhancement New feature or request labels Mar 9, 2021
@ndmitchell
Copy link
Collaborator

I'd rather delete it - I doubt anyone sets it custom, and less configuration is always less testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants