Skip to content

Commit a0baa4d

Browse files
jhrcekmichaelpj
andauthored
Fix -Wall and -Wunused-packages in stan plugin (#4014)
* Fix -Wall and -Wunused-packages in stan plugin * Rename binding --------- Co-authored-by: Michael Peyton Jones <me@michaelpj.com>
1 parent 5c11636 commit a0baa4d

File tree

2 files changed

+2
-12
lines changed

2 files changed

+2
-12
lines changed

haskell-language-server.cabal

-6
Original file line numberDiff line numberDiff line change
@@ -676,17 +676,13 @@ library hls-stan-plugin
676676
hs-source-dirs: plugins/hls-stan-plugin/src
677677
build-depends:
678678
base
679-
, containers
680-
, data-default
681679
, deepseq
682680
, hashable
683681
, hie-compat
684682
, hls-plugin-api
685-
, ghc
686683
, ghcide
687684
, lsp-types
688685
, text
689-
, transformers
690686
, unordered-containers
691687
, stan >= 0.1.2.0
692688
, trial
@@ -711,9 +707,7 @@ test-suite hls-stan-plugin-tests
711707
hs-source-dirs: plugins/hls-stan-plugin/test
712708
main-is: Main.hs
713709
build-depends:
714-
aeson
715710
, base
716-
, containers
717711
, filepath
718712
, haskell-language-server:hls-stan-plugin
719713
, hls-plugin-api

plugins/hls-stan-plugin/src/Ide/Plugin/Stan.hs

+2-6
Original file line numberDiff line numberDiff line change
@@ -80,9 +80,6 @@ stripModifiers = go ""
8080
Nothing -> txt
8181
Just index -> T.drop (index + 1) txt
8282

83-
renderId :: Id a -> T.Text
84-
renderId (Id t) = "Id = " <> t
85-
8683
instance Pretty Log where
8784
pretty = \case
8885
LogShake log -> pretty log
@@ -136,12 +133,11 @@ rules recorder plId = do
136133
}
137134

138135
(configTrial, useDefConfig, env) <- liftIO $ getStanConfig stanArgs isLoud
139-
seTomlFiles <- liftIO $ usedTomlFiles useDefConfig (stanArgsConfigFile stanArgs)
140-
logWith recorder Debug (LogDebugStanConfigResult seTomlFiles configTrial)
136+
tomlsUsedByStan <- liftIO $ usedTomlFiles useDefConfig (stanArgsConfigFile stanArgs)
137+
logWith recorder Debug (LogDebugStanConfigResult tomlsUsedByStan configTrial)
141138

142139
-- If envVar is set to 'False', stan will ignore all local and global .stan.toml files
143140
logWith recorder Debug (LogDebugStanEnvVars env)
144-
seTomlFiles <- liftIO $ usedTomlFiles useDefConfig (stanArgsConfigFile stanArgs)
145141

146142
-- Note that Stan works in terms of relative paths, but the HIE come in as absolute. Without
147143
-- making its path relative, the file name(s) won't line up with the associated Map keys.

0 commit comments

Comments
 (0)