allow slashes in git url parameters #35552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Git url refs often contain slashes, which were incorrectly being split and appended to the path as a go-getter subdir.
liamcervante
approved these changes
Aug 12, 2024
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Git URL refs often contain slashes, and while it's technically not correct to have unencoded slashes in the query, they were being split off and incorrectly appended to the path as a go-getter subdir. (This was likely part of the PR which pulled a lot of the behavior into the Terraform repo #34847) The behavior was definitely incorrect, and since Terraform apparently accepted unencoded slashes in query parameters in the past, we can just restore the prior behavior rather than rejecting unencoded slashes entirely.
Fixes #34554