Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove interpolation-only warning #27835

Merged
merged 1 commit into from
Feb 19, 2021
Merged

Remove interpolation-only warning #27835

merged 1 commit into from
Feb 19, 2021

Conversation

pselle
Copy link
Contributor

@pselle pselle commented Feb 19, 2021

These interpolations are removed when upgrading using 0.12upgrade, and are removed in terraform fmt in many cases.

I checked to see if some cases aren't currently fixed by fmt and it appears cases like ["${var.foo}"] aren't fixed by fmt, but others are. I think this is acceptable/follow-on work to fmt can be done if wanted.

These interpolations are removed when upgrading using 0.12upgrade,
and are removed in terraform fmt in many cases
@pselle pselle force-pushed the pselle/warn-interpolation branch from f3eb57a to fa7c3d7 Compare February 19, 2021 15:59
@codecov
Copy link

codecov bot commented Feb 19, 2021

Codecov Report

Merging #27835 (fa7c3d7) into master (28d3505) will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted Files Coverage Δ
command/format/diagnostic.go 69.42% <ø> (ø)
configs/compat_shim.go 90.24% <ø> (-5.06%) ⬇️
configs/module_call.go 68.49% <ø> (-0.85%) ⬇️
configs/named_values.go 67.35% <ø> (-0.54%) ⬇️
configs/provider.go 82.52% <ø> (-0.34%) ⬇️
configs/resource.go 80.95% <ø> (-0.30%) ⬇️
internal/getproviders/didyoumean.go 54.32% <ø> (ø)
internal/getproviders/filesystem_search.go 63.20% <ø> (ø)
internal/legacy/terraform/resource_address.go 62.31% <ø> (ø)
provider_source.go 24.73% <ø> (ø)
... and 5 more

@pselle pselle requested a review from a team February 19, 2021 16:05
@pselle pselle merged commit e5274f9 into master Feb 19, 2021
@pselle pselle deleted the pselle/warn-interpolation branch February 19, 2021 21:13
@ghost
Copy link

ghost commented Mar 22, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Mar 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants