Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: hashicorp/go-getter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.7.5
Choose a base ref
...
head repository: hashicorp/go-getter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.7.6
Choose a head ref
  • 3 commits
  • 2 files changed
  • 3 contributors

Commits on Jul 24, 2024

  1. Fix panic when s3 URL is invalid 

    Gracefully handle when S3 URLs have an unexpected number of path segments.

Currently we expect `s3.amazonaws.com/bucket/path`, but something like `s3.amazonaws.com/bucket` will cause a panic, e.g.

```
panic: runtime error: index out of range [2] with length 2

github.com/hashicorp/go-getter.(*S3Getter).parseUrl(,)
    /go/pkg/mod/github.com/hashicorp/go-getter@v1.7.5/get_s3.go:272
github.com/hashicorp/go-getter.(*S3Getter).Get(, {,},)
    /go/pkg/mod/git...
```
    @liamg
    liamg authored Jul 24, 2024
    Configuration menu
    Copy the full SHA
    83fd927 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2024

  1. add tests

    @liamg
    liamg committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    8339301 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. Merge pull request #501 from liamg/patch-1 

    fix: Avoid panic when s3 URL is invalid
    @radeksimko
    radeksimko authored Aug 14, 2024
    Configuration menu
    Copy the full SHA
    4f07d24 View commit details
    Browse the repository at this point in the history
Loading