fix(use): process global is not available in all environments and NODE_ENV doesn't necessarily depict production vs. development

Author: enisdenjo

src/use/express.ts

@@ -43,7 +43,6 @@ export type HandlerOptions<Context extends OperationContext = undefined> =
 export function createHandler<Context extends OperationContext = undefined>(
   options: HandlerOptions<Context>,
 ): Handler {
-  const isProd = process.env.NODE_ENV === 'production';
   const handle = createRawHandler(options);
   return async function requestListener(req, res) {
     try {
@@ -74,24 +73,7 @@ export function createHandler<Context extends OperationContext = undefined>(
           'Please check your implementation.',
         err,
       );
-      if (isProd) {
-        res.writeHead(500).end();
-      } else {
-        res
-          .writeHead(500, { 'content-type': 'application/json; charset=utf-8' })
-          .end(
-            JSON.stringify({
-              errors: [
-                err instanceof Error
-                  ? {
-                      message: err.message,
-                      stack: err.stack,
-                    }
-                  : err,
-              ],
-            }),
-          );
-      }
+      res.writeHead(500).end();
     }
   };
 }

src/use/fastify.ts

@@ -43,7 +43,6 @@ export type HandlerOptions<Context extends OperationContext = undefined> =
 export function createHandler<Context extends OperationContext = undefined>(
   options: HandlerOptions<Context>,
 ): RouteHandler {
-  const isProd = process.env.NODE_ENV === 'production';
   const handle = createRawHandler(options);
   return async function requestListener(req, reply) {
     try {
@@ -69,23 +68,7 @@ export function createHandler<Context extends OperationContext = undefined>(
           'Please check your implementation.',
         err,
       );
-      if (isProd) {
-        reply.status(500).send();
-      } else {
-        reply
-          .status(500)
-          .header('content-type', 'application/json; charset=utf-8')
-          .send({
-            errors: [
-              err instanceof Error
-                ? {
-                    message: err.message,
-                    stack: err.stack,
-                  }
-                : err,
-            ],
-          });
-      }
+      reply.status(500).send();
     }
   };
 }

src/use/fetch.ts

@@ -55,7 +55,6 @@ export function createHandler<Context extends OperationContext = undefined>(
   options: HandlerOptions<Context>,
   reqCtx: Partial<FetchAPI> = {},
 ): (req: Request) => Promise<Response> {
-  const isProd = process.env.NODE_ENV === 'production';
   const api: FetchAPI = {
     Response: reqCtx.Response || Response,
     TextEncoder: reqCtx.TextEncoder || TextEncoder,
@@ -81,28 +80,7 @@ export function createHandler<Context extends OperationContext = undefined>(
           'Please check your implementation.',
         err,
       );
-      if (isProd) {
-        return new api.Response(null, { status: 500 });
-      } else {
-        return new api.Response(
-          JSON.stringify({
-            errors: [
-              err instanceof Error
-                ? {
-                    message: err.message,
-                    stack: err.stack,
-                  }
-                : err,
-            ],
-          }),
-          {
-            status: 500,
-            headers: {
-              'content-type': 'application/json; charset=utf-8',
-            },
-          },
-        );
-      }
+      return new api.Response(null, { status: 500 });
     }
   };
 }

src/use/http.ts

@@ -42,7 +42,6 @@ export type HandlerOptions<Context extends OperationContext = undefined> =
 export function createHandler<Context extends OperationContext = undefined>(
   options: HandlerOptions<Context>,
 ): (req: IncomingMessage, res: ServerResponse) => Promise<void> {
-  const isProd = process.env.NODE_ENV === 'production';
   const handle = createRawHandler(options);
   return async function requestListener(req, res) {
     try {
@@ -74,24 +73,7 @@ export function createHandler<Context extends OperationContext = undefined>(
           'Please check your implementation.',
         err,
       );
-      if (isProd) {
-        res.writeHead(500).end();
-      } else {
-        res
-          .writeHead(500, { 'content-type': 'application/json; charset=utf-8' })
-          .end(
-            JSON.stringify({
-              errors: [
-                err instanceof Error
-                  ? {
-                      message: err.message,
-                      stack: err.stack,
-                    }
-                  : err,
-              ],
-            }),
-          );
-      }
+      res.writeHead(500).end();
     }
   };
 }

src/use/http2.ts

@@ -54,7 +54,6 @@ export type HandlerOptions<Context extends OperationContext = undefined> =
 export function createHandler<Context extends OperationContext = undefined>(
   options: HandlerOptions<Context>,
 ): (req: Http2ServerRequest, res: Http2ServerResponse) => Promise<void> {
-  const isProd = process.env.NODE_ENV === 'production';
   const handle = createRawHandler(options);
   return async function requestListener(req, res) {
     try {
@@ -91,24 +90,7 @@ export function createHandler<Context extends OperationContext = undefined>(
           'Please check your implementation.',
         err,
       );
-      if (isProd) {
-        res.writeHead(500).end();
-      } else {
-        res
-          .writeHead(500, { 'content-type': 'application/json; charset=utf-8' })
-          .end(
-            JSON.stringify({
-              errors: [
-                err instanceof Error
-                  ? {
-                      message: err.message,
-                      stack: err.stack,
-                    }
-                  : err,
-              ],
-            }),
-          );
-      }
+      res.writeHead(500).end();
     }
   };
 }

src/use/koa.ts

@@ -45,7 +45,6 @@ export type HandlerOptions<Context extends OperationContext = undefined> =
 export function createHandler<Context extends OperationContext = undefined>(
   options: HandlerOptions<Context>,
 ): Middleware {
-  const isProd = process.env.NODE_ENV === 'production';
   const handle = createRawHandler(options);
   return async function requestListener(ctx) {
     try {
@@ -84,19 +83,6 @@ export function createHandler<Context extends OperationContext = undefined>(
         err,
       );
       ctx.response.status = 500;
-      if (!isProd) {
-        ctx.response.set('content-type', 'application/json; charset=utf-8');
-        ctx.body = {
-          errors: [
-            err instanceof Error
-              ? {
-                  message: err.message,
-                  stack: err.stack,
-                }
-              : err,
-          ],
-        };
-      }
     }
   };
 }