Add subdirectories to tested folders in Github workflow (#108)

* Add subdirectories to tested folders in Github workflow

* Fix Header test

* Fix Fprint redundant newline errors

* Increase Github workflow timeout for test job

* Update set-env and add-path in Github workflow

https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

Author: MarkKremer

.github/workflows/.go.yml

@@ -20,6 +20,7 @@ jobs:
             allowfail: true
     runs-on: ${{ matrix.os }}
     continue-on-error: ${{ matrix.allowfail }}
+    timeout-minutes: 5
     steps:
     - name: Install Go ${{ matrix.go }} on ${{ matrix.os }}
       if: matrix.go != 'tip'
@@ -34,14 +35,14 @@ jobs:
         git clone --depth=1 https://go.googlesource.com/go $HOME/gotip
         cd $HOME/gotip/src
         ./make.bash
-        echo "::set-env name=GOROOT::$HOME/gotip"
-        echo "::add-path::$HOME/gotip/bin"
+        echo "GOROOT=$HOME/gotip" >> $GITHUB_ENV
+        echo "$HOME/gotip/bin" >> $GITHUB_PATH
     - name: Checkout code
       uses: actions/checkout@v2
     - name: Run tests
       run: |
-        go test -v -race
-        go test -race -tags=${{ matrix.tags }}
+        go test ./... -v -race
+        go test ./... -race -tags=${{ matrix.tags }}
 
   coverage:
     env:
@@ -70,7 +71,7 @@ jobs:
     - name: Calc coverage
       run: |
         export PATH=$PATH:$(go env GOPATH)/bin
-        go test -v -covermode=atomic -coverprofile=coverage.out
+        go test ./... -v -covermode=atomic -coverprofile=coverage.out
     - name: Convert coverage to lcov
       uses: jandelgado/gcov2lcov-action@v1.0.0
       with:

genlib2/dense_io.go

@@ -657,29 +657,29 @@ func init() {
 func generateDenseIO(f io.Writer, generic Kinds) {
 	mk := Kinds{Kinds: filter(generic.Kinds, isNumber)}
 
-	fmt.Fprintln(f, "/* GOB SERIALIZATION */\n")
+	fmt.Fprint(f, "/* GOB SERIALIZATION */\n\n")
 	gobEncode.Execute(f, mk)
 	gobDecode.Execute(f, mk)
 	fmt.Fprint(f, "\n")
 
-	fmt.Fprintln(f, "/* NPY SERIALIZATION */\n")
+	fmt.Fprint(f, "/* NPY SERIALIZATION */\n\n")
 	fmt.Fprintln(f, npyDescRE)
 	fmt.Fprintln(f, rowOrderRE)
 	fmt.Fprintln(f, shapeRE)
 	fmt.Fprintln(f, writeNpyRaw)
 	readNpy.Execute(f, mk)
 	fmt.Fprint(f, "\n")
 
-	fmt.Fprintln(f, "/* CSV SERIALIZATION */\n")
+	fmt.Fprint(f, "/* CSV SERIALIZATION */\n\n")
 	fmt.Fprintln(f, writeCSVRaw)
 	readCSV.Execute(f, mk)
 	fmt.Fprint(f, "\n")
 
-	fmt.Fprintln(f, "/* FB SERIALIZATION */\n")
+	fmt.Fprint(f, "/* FB SERIALIZATION */\n\n")
 	fmt.Fprintln(f, fbEncodeDecodeRaw)
 	fmt.Fprint(f, "\n")
 
-	fmt.Fprintln(f, "/* PB SERIALIZATION */\n")
+	fmt.Fprint(f, "/* PB SERIALIZATION */\n\n")
 	fmt.Fprintln(f, pbEncodeDecodeRaw)
 	fmt.Fprint(f, "\n")
 

internal/storage/header_test.go

@@ -3,7 +3,6 @@ package storage
 import (
 	"reflect"
 	"testing"
-	"unsafe"
 
 	"github.com/stretchr/testify/assert"
 )
@@ -14,30 +13,26 @@ func TestFill(t *testing.T) {
 	b := headerFromSlice([]int{10, 11})
 	copied := Fill(reflect.TypeOf(1), &a, &b)
 
-	assert.Equal(t, copied, 5)
-	assert.Equal(t, a.Ints(), []int{10, 11, 10, 11, 10})
+	assert.Equal(t, 5, copied)
+	assert.Equal(t, []int{10, 11, 10, 11, 10}, a.Ints())
 
 	// B longer than A
 	a = headerFromSlice([]int{10, 11})
 	b = headerFromSlice([]int{0, 1, 2, 3, 4})
 	copied = Fill(reflect.TypeOf(1), &a, &b)
 
-	assert.Equal(t, copied, 2)
-	assert.Equal(t, a.Ints(), []int{0, 1})
+	assert.Equal(t, 2, copied)
+	assert.Equal(t, []int{0, 1}, a.Ints())
 }
 
 func headerFromSlice(x interface{}) Header {
 	xT := reflect.TypeOf(x)
 	if xT.Kind() != reflect.Slice {
 		panic("Expected a slice")
 	}
-
 	xV := reflect.ValueOf(x)
-	uptr := unsafe.Pointer(xV.Pointer())
-
+	size := uintptr(xV.Len()) * xT.Elem().Size()
 	return Header{
-		Ptr: uptr,
-		L:   xV.Len(),
-		C:   xV.Cap(),
+		Raw: FromMemory(xV.Pointer(), size),
 	}
 }