Skip to content

Commit c1c8ce1

Browse files
author
Yoshi Yamaguchi
authoredApr 21, 2023
feat: add logic to convert severity string to uppercase (#744)
1 parent 7baafa0 commit c1c8ce1

File tree

3 files changed

+97
-71
lines changed

3 files changed

+97
-71
lines changed
 

Diff for: ‎google/cloud/logging_v2/entries.py

+4-1
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,10 @@ def to_api_repr(self):
229229
if self.insert_id is not None:
230230
info["insertId"] = self.insert_id
231231
if self.severity is not None:
232-
info["severity"] = self.severity
232+
if isinstance(self.severity, str):
233+
info["severity"] = self.severity.upper()
234+
else:
235+
info["severity"] = self.severity
233236
if self.http_request is not None:
234237
info["httpRequest"] = self.http_request
235238
if self.timestamp is not None:

Diff for: ‎google/cloud/logging_v2/logger.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ def _do_log(self, client, _entry_class, payload=None, **kw):
141141
kw["resource"] = kw.pop("resource", self.default_resource)
142142

143143
severity = kw.get("severity", None)
144-
if isinstance(severity, str) and not severity.isupper():
144+
if isinstance(severity, str):
145145
# convert severity to upper case, as expected by enum definition
146146
kw["severity"] = severity.upper()
147147

0 commit comments

Comments
 (0)
Please sign in to comment.