Skip to content

Need to update pageToken to nextPageToken #1560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sofisl opened this issue Mar 24, 2025 · 0 comments
Open

Need to update pageToken to nextPageToken #1560

sofisl opened this issue Mar 24, 2025 · 0 comments
Assignees
@cindy-peng
Labels
api: logging Issues related to the googleapis/nodejs-logging API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@sofisl
Copy link
Contributor

sofisl commented Mar 24, 2025

see https://buganizer.corp.google.com/issues/391720095#comment17

We need to update this type

nodejs-logging/src/log.ts

Line 47 in 9d1d480

pageToken?: string;
to actually match the correct token returned nextPageToken
@sofisl sofisl added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Mar 24, 2025
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/nodejs-logging API. label Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cindy-peng cindy-peng

Labels
api: logging Issues related to the googleapis/nodejs-logging API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sofisl @cindy-peng