x/review/git-codereview: TestHooks and 5 more related tests are failing as of "os: avoid symlink races in RemoveAll" on Windows

[dmitshur]

As seen on the x/review (gotip) by go commit view, a number of tests have begun to fail starting with CL 661575:

=== RUN   TestHooks
    hook_test.go:411: git-codereview hooks
    util_test.go:359: died
        stdout:
        stderr:
        git-codereview: Hooks files C:\b\s\w\ir\x\t\git-codereview-test1342507340\git-client\.git\hooks\commit-msg, C:\b\s\w\ir\x\t\git-codereview-test1342507340\git-client\.git\hooks\pre-commit already exist.
        To install git-codereview hooks, delete these files and re-run 'git-codereview hooks'.
--- FAIL: TestHooks (1.07s)

CC @golang/windows, @neild.

[gabyhelp]

Related Code Changes

• os: avoid symlink races in RemoveAll on Windows

_{(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)}

[gopherbot]

Change https://go.dev/cl/664715 mentions this issue: os: handle trailing slashes in os.RemoveDir on Windows