x/review/git-codereview: change -n still writes the hooks without announcing

[abitrolly]

According to usage, -n should not result in any changes to repository.

The -n flag prints commands that would make changes but does not run them.

But that's not the case for hooks.

➜ .git/hooks/pre-commit
➜ ls -la .git/hooks/pre-commit
ls: cannot access '.git/hooks/pre-commit': No such file or directory
➜ ~/go/bin/git-codereview change -n
git-codereview: warning: unstaged changes and no staged changes; use 'git add' or 'git change -a'
git commit -q --allow-empty
git-codereview: change updated.
➜ ls -la .git/hooks/pre-commit
-rwx------. 1 anatoli anatoli 58 Apr 10 18:00 .git/hooks/pre-commit

Then my repo becomes broken, because git-codereview does not exist in PATH.

I expect hook handler to report what they are doing and respect -n flag.

[dmitshur]

Thanks for reporting.

This should be a matter of adding a check for *noRun inside installHook, before it starts to do os.Mkdir and os.WriteFile.

[abitrolly]

@dmitshur it required a few more checks to be completely safe https://go-review.googlesource.com/c/review/+/664555

[gopherbot]

Change https://go.dev/cl/664555 mentions this issue: git-codereview: do not write hooks if -n is given

[abitrolly]

Added a proposal to support full issue URLs #73320