chore(issues): Opt in a few more endpoint tests to stronger types (#82382)

`tests.sentry.issues.endpoints.test_organization_group_index` is the
only remaining before we can just fully opt in
`tests.sentry.issues.endpoints.*`.

Author: mrduncan

Diff for: pyproject.toml

@@ -511,8 +511,12 @@ module = [
     "tests.sentry.issues.endpoints.test_group_activities",
     "tests.sentry.issues.endpoints.test_group_details",
     "tests.sentry.issues.endpoints.test_group_event_details",
+    "tests.sentry.issues.endpoints.test_group_events",
     "tests.sentry.issues.endpoints.test_group_hashes",
     "tests.sentry.issues.endpoints.test_group_notes",
+    "tests.sentry.issues.endpoints.test_group_notes_details",
+    "tests.sentry.issues.endpoints.test_group_participants",
+    "tests.sentry.issues.endpoints.test_group_similar_issues_embeddings",
     "tests.sentry.issues.endpoints.test_group_tombstone",
     "tests.sentry.issues.endpoints.test_group_tombstone_details",
     "tests.sentry.issues.endpoints.test_organization_group_search_views",
@@ -521,6 +525,7 @@ module = [
     "tests.sentry.issues.endpoints.test_project_group_stats",
     "tests.sentry.issues.endpoints.test_project_stacktrace_link",
     "tests.sentry.issues.endpoints.test_related_issues",
+    "tests.sentry.issues.endpoints.test_shared_group_details",
     "tests.sentry.issues.endpoints.test_source_map_debug",
     "tests.sentry.issues.endpoints.test_team_groups_old",
     "tests.sentry.issues.test_attributes",

Diff for: tests/sentry/issues/endpoints/test_group_events.py

@@ -1,6 +1,7 @@
 from datetime import timedelta
 
 from django.utils import timezone
+from rest_framework.response import Response
 
 from sentry.issues.grouptype import ProfileFileIOGroupType
 from sentry.testutils.cases import APITestCase, PerformanceIssueTestCase, SnubaTestCase
@@ -15,10 +16,10 @@ def setUp(self) -> None:
         self.min_ago = before_now(minutes=1)
         self.two_min_ago = before_now(minutes=2)
 
-    def do_request(self, url: str):
+    def do_request(self, url: str) -> Response:
         return self.client.get(url, format="json")
 
-    def _parse_links(self, header):
+    def _parse_links(self, header: str) -> dict[str | None, dict[str, str | None]]:
         # links come in {url: {...attrs}}, but we need {rel: {...attrs}}
         links = {}
         for url, attrs in parse_link_header(header).items():

Diff for: tests/sentry/issues/endpoints/test_group_notes_details.py

@@ -1,5 +1,5 @@
 from functools import cached_property
-from unittest.mock import patch
+from unittest.mock import MagicMock, patch
 
 import responses
 
@@ -16,7 +16,7 @@
 
 
 class GroupNotesDetailsTest(APITestCase):
-    def setUp(self):
+    def setUp(self) -> None:
         super().setUp()
         self.activity.data["external_id"] = "123"
         self.activity.save()
@@ -43,10 +43,10 @@ def setUp(self):
         )
 
     @cached_property
-    def url(self):
+    def url(self) -> str:
         return f"/api/0/issues/{self.group.id}/comments/{self.activity.id}/"
 
-    def test_delete(self):
+    def test_delete(self) -> None:
         self.login_as(user=self.user)
 
         url = self.url
@@ -59,7 +59,7 @@ def test_delete(self):
 
         assert Group.objects.get(id=self.group.id).num_comments == 0
 
-    def test_delete_comment_and_subscription(self):
+    def test_delete_comment_and_subscription(self) -> None:
         """Test that if a user deletes their comment on an issue, we delete the subscription too"""
         self.login_as(user=self.user)
         event = self.store_event(data={}, project_id=self.project.id)
@@ -91,7 +91,7 @@ def test_delete_comment_and_subscription(self):
             reason=GroupSubscriptionReason.comment,
         ).exists()
 
-    def test_delete_multiple_comments(self):
+    def test_delete_multiple_comments(self) -> None:
         """Test that if a user has commented multiple times on an issue and deletes one, we don't remove the subscription"""
         self.login_as(user=self.user)
         event = self.store_event(data={}, project_id=self.project.id)
@@ -130,7 +130,7 @@ def test_delete_multiple_comments(self):
 
     @patch("sentry.integrations.mixins.issues.IssueBasicIntegration.update_comment")
     @responses.activate
-    def test_put(self, mock_update_comment):
+    def test_put(self, mock_update_comment: MagicMock) -> None:
         self.login_as(user=self.user)
 
         url = self.url
@@ -154,7 +154,7 @@ def test_put(self, mock_update_comment):
         assert mock_update_comment.call_args[0][2] == activity
 
     @responses.activate
-    def test_put_ignore_mentions(self):
+    def test_put_ignore_mentions(self) -> None:
         GroupLink.objects.filter(group_id=self.group.id).delete()
         self.login_as(user=self.user)
 
@@ -179,7 +179,7 @@ def test_put_ignore_mentions(self):
         }
 
     @patch("sentry.integrations.mixins.issues.IssueBasicIntegration.update_comment")
-    def test_put_no_external_id(self, mock_update_comment):
+    def test_put_no_external_id(self, mock_update_comment: MagicMock) -> None:
         del self.activity.data["external_id"]
         self.activity.save()
         self.login_as(user=self.user)

Diff for: tests/sentry/issues/endpoints/test_group_participants.py

@@ -1,13 +1,16 @@
+from collections.abc import Callable
+
+from sentry.models.group import Group
 from sentry.models.groupsubscription import GroupSubscription
 from sentry.testutils.cases import APITestCase
 
 
 class GroupParticipantsTest(APITestCase):
-    def setUp(self):
+    def setUp(self) -> None:
         super().setUp()
         self.login_as(self.user)
 
-    def _get_path_functions(self):
+    def _get_path_functions(self) -> tuple[Callable[[Group], str], Callable[[Group], str]]:
         # The urls for group participants are supported both with an org slug and without.
         # We test both as long as we support both.
         # Because removing old urls takes time and consideration of the cost of breaking lingering references, a
@@ -17,7 +20,7 @@ def _get_path_functions(self):
             lambda group: f"/api/0/organizations/{self.organization.slug}/issues/{group.id}/participants/",
         )
 
-    def test_simple(self):
+    def test_simple(self) -> None:
         group = self.create_group()
         GroupSubscription.objects.create(
             user_id=self.user.id, group=group, project=group.project, is_active=True