Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mods that prevent MoreCulling from working #6

Closed
FxMorin opened this issue Jun 4, 2022 · 24 comments
Closed

Mods that prevent MoreCulling from working #6

FxMorin opened this issue Jun 4, 2022 · 24 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@FxMorin
Copy link
Owner

FxMorin commented Jun 4, 2022

This issue will be used as a list of mods that currently don't support MoreCulling so that I can go through the mods and fix the issues.

This has now moved over to Compatibility Testing

Supported Rendering Engines

Currently Unsupported Mods

  • None

Currently Unsupported Rendering Engines

  • None

Rendering Engines that need testing

Mods that need testing

I will put putting all this info into a wiki page before the official release of the mod. Once this is no longer an Alpha build


If you want to test if the mod is working, an easy way to do this is by using a chorus plant, and testing this bug
There might be an automated system in the future, although don't get your hopes up

@FxMorin FxMorin added good first issue Good for newcomers help wanted Extra attention is needed labels Jun 4, 2022
@ardissaps
Copy link

so basicaly i should remove this mod if i have sodium?

Repository owner deleted a comment from ardissaps Jun 4, 2022
@FxMorin
Copy link
Owner Author

FxMorin commented Jun 4, 2022

It shouldn't do anything if you have sodium, so yes. I'm currently fixing that

@ardissaps
Copy link

It shouldn't do anything if you have sodium, so yes. I'm currently fixing that

Is this different from Sodium builtin culling also from below mod ?
https://modrinth.com/mod/entityculling

@FxMorin
Copy link
Owner Author

FxMorin commented Jun 4, 2022

Blockstate culling, not at all related to entity culling or sodium culling

@ardissaps
Copy link

Blockstate culling, not at all related to entity culling or sodium culling

How about Cull Leaves?

@FxMorin
Copy link
Owner Author

FxMorin commented Jun 4, 2022

No, only blocks that have non-full block hitboxes are currently affected. No mod exists that does this like mine currently

@Scarlaid
Copy link

Scarlaid commented Jun 4, 2022

Running with Continuity fine here 😁

@Scarlaid
Copy link

Scarlaid commented Jun 4, 2022

what about this mod? - CullLessLeaves
nvm I saw fxmorin comment

@FxMorin
Copy link
Owner Author

FxMorin commented Jun 4, 2022

Running with Continuity fine here 😁

Does it pass the chorus plant test?

@Scarlaid
Copy link

Scarlaid commented Jun 4, 2022

Running with Continuity fine here 😁

Does it pass the chorus plant test?

Been playing on a server a while with Continuity, no crash
Going back to singleplayer creative world to recheck if it spamming the log while looking at Chorus Plant, dont seem to see it, and no crash

image
huge_2022-06-04_22 21 54

@FxMorin
Copy link
Owner Author

FxMorin commented Jun 4, 2022

@Scarlaid I meant this bug https://bugs.mojang.com/browse/MC-249693 that I linked in the issue. I need to know if continuity just overrides it or not if the chorus internals are culled then it works.

@NaiNonTH
Copy link

NaiNonTH commented Jun 4, 2022

It works with Sodium for me, which idk why, but it doesn't work with CullLessLeaves mod.

But hey, at least it still works with Cull Leaves.

@NaiNonTH
Copy link

NaiNonTH commented Jun 4, 2022

It works with Sodium for me, which idk why, but it doesn't work with CullLessLeaves mod.

But hey, at least it still works with Cull Leaves.

Also, still works with continuity for me.

@isXander
Copy link

isXander commented Jun 4, 2022

Sodium has a BlockOcclusionCache (see CullLessLeaves for integration)

@FxMorin
Copy link
Owner Author

FxMorin commented Jun 4, 2022

@isXander It's already patched, just not in a release

@FwuffyPetsOwO
Copy link

@FxMorin Version 0.2.0 on 1.19 properly culls all affected blocks when used with Continuity. I used spectator mode to confirm.

@FxMorin
Copy link
Owner Author

FxMorin commented Jun 12, 2022

cool thanks

@RaptaG
Copy link
Contributor

RaptaG commented Jun 16, 2022

FREX seems to work:
2022-06-16_15 29 29
Crashlog: https://mclo.gs/BfWvcab

@FxMorin
Copy link
Owner Author

FxMorin commented Jun 16, 2022

@RaptaG I need you to actually go into the chorus fruit. That image tells me nothing, also what's that crashlog?

@RaptaG
Copy link
Contributor

RaptaG commented Jun 16, 2022

@RaptaG I need you to actually go into the chorus fruit. That image tells me nothing, also what's that crashlog?

Ok, I'll do that. The crashlog is for you if you wanted to check anything there.

@barackenkumpel
Copy link

Chorus plant culling works for me with Iris and Indium.

@RaptaG
Copy link
Contributor

RaptaG commented Jul 6, 2022

Does LBG still causes problems?

@RaptaG
Copy link
Contributor

RaptaG commented Jul 11, 2022

The description is outdated..

@FxMorin
Copy link
Owner Author

FxMorin commented Jul 11, 2022

Due to the mod no longer being Alpha. I have moved it into its own discussion.
#31 (comment)

@FxMorin FxMorin closed this as completed Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

8 participants