fix: remove injectIntl types from component props #1415
Conversation
| : T extends 'formatTime' | ||
| ? FormatDateOptions | ||
| : FormatNumberOptions; | ||
|
|
||
| const displayNames: { |
There was a problem hiding this comment.
enum DisplayName {
formatDate = 'FormattedDate',
formatTime = 'FormattedTime',
formatNumber = 'FormattedNumber',
}
DisplayName['formatDate'] // the value is "FormattedDate"There was a problem hiding this comment.
I would personally avoid using enums
There was a problem hiding this comment.
There was a problem hiding this comment.
Hmm sorry, I'm not sure I understand what you need me to do here 🤔
There was a problem hiding this comment.
const enum DisplayName {
formatDate = 'FormattedDate',
formatTime = 'FormattedTime',
formatNumber = 'FormattedNumber',
}in component:
Component.displayName = DisplayName[name];There was a problem hiding this comment.
I'm getting this error:
There was a problem hiding this comment.
Ah thanks, I never used enum so my knowledge of it is a bit limited.
emmenko
force-pushed
the
nm-fix-types-props
branch
from
f0f4b78 to
8d78476
Compare
|
@septs thanks for the feedback so far! Further improvements can be done as follow ups. |
| }; | ||
|
|
||
| const Component = (props: Props) => ( |
There was a problem hiding this comment.
#1416 not use any then
const Component: React.FC<Props> = (props) => {
// ... code ...
}React.FC definition: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/981cc6d51eb213943a3606c14ad75d65ea6b360f/types/react/index.d.ts#L493-L501
There was a problem hiding this comment.
Hmm what issue should this solve exactly? Also, can you explain how using React.FC is different from props: Props? 🤔
There was a problem hiding this comment.
expand React.FC<Props> definition
get (props: Props, context?: any) => React.ReactElement | null
There was a problem hiding this comment.
yeah const Component: React.FC<Props> = props => gives u the correct type definition
There was a problem hiding this comment.
Just to clarify, what do you mean by the correct type definition?
Using props: Props is not wrong, this is also what you find in the TS docs
I'm also not against using React.FC if you want to, I just want to understand what are the benefits of using that compared to props: Props.
| }; | ||
|
|
||
| const Component = (props: Props) => ( |
There was a problem hiding this comment.
yeah const Component: React.FC<Props> = props => gives u the correct type definition
| : T extends 'formatTime' | ||
| ? FormatDateOptions | ||
| : FormatNumberOptions; | ||
|
|
||
| const displayNames: { |
There was a problem hiding this comment.
const enum would work here I believe?
* fix: remove unused WrappedComponentProps type * refactor: don't use HOC for formatted component factory * refactor: simplify types interface * refactor: simplify code * refactor: simplify code * refactor: keep using React.FC * refactor: to use enum for DisplayName options fixes #1414
Leftover of #1413
Fixes #1414