Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Combining bold italic strikethrough can generate invalid markdown #2303

Closed
hanford opened this issue May 31, 2022 · 3 comments
Closed

Bug: Combining bold italic strikethrough can generate invalid markdown #2303

hanford opened this issue May 31, 2022 · 3 comments
Labels
all-platforms-bug markdown

Comments

@hanford
Copy link
Contributor

hanford commented May 31, 2022 •
edited
Loading

Combining Bold, Italic and strikethrough formats can generate invalid markdown

Lexical version: 0.2.9

Steps To Reproduce

  1. Enable Bold, type (Bold )
  2. Enable Italic, type (Italic )
  3. Enable strike through, type (bold italic strikethrough)
  4. View generated markdown

Note that the generated markdown is:

**bold *italic ~~strikethrough***~~

Which escapes strikethrough incorrectly, it should be

**bold *italic ~~strikethrough~~***

The current behavior

Invalid markdown is generated

The expected behavior

Proper markdown should be generated

Current bad state
Screen Shot 2022-05-31 at 12 42 06 PM

Screen Shot 2022-05-31 at 12 36 29 PM

Fixed state with open PR:
Screen Shot 2022-05-31 at 12 42 33 PM
Screen Shot 2022-05-31 at 12 36 55 PM
@hanford hanford mentioned this issue May 31, 2022
Closed
@digitalgopnik
Copy link
Contributor

👍

@hanford hanford mentioned this issue Aug 3, 2022
Closed
@thegreatercurve thegreatercurve self-assigned this Nov 24, 2022
@thegreatercurve thegreatercurve removed their assignment Mar 3, 2023
@Nantris
Copy link

Nantris commented Apr 20, 2023

It appears there was a PR for this in #2304? Does anyone know why it wasn't committed?

@yhw5 yhw5 mentioned this issue Mar 23, 2024
Merged
@GermanJablo GermanJablo mentioned this issue Sep 23, 2024
Closed
@etrepum etrepum mentioned this issue Dec 16, 2024
Closed
@etrepum
Copy link
Collaborator

etrepum commented Dec 16, 2024

Should be fixed by #5758

@etrepum etrepum closed this as completed Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
all-platforms-bug markdown
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

@lexical/markdown Fix strikethrough TextFormatTransformer order hanford/lexical
6 participants
@etrepum @zurfyx @hanford @digitalgopnik @Nantris @thegreatercurve