Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the outdated diagnostics when the code action for creating a missing element is invoked #2664

Merged

Conversation

testforstephen
Copy link
Contributor

@testforstephen testforstephen commented May 23, 2023

This PR is used to workaround the side effect introduced by PR #2587.

Copy link
Contributor

@jdneo jdneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@testforstephen
Copy link
Contributor Author

The failed test case is irrelevant with this PR. Locally this failed case can pass, looks like a random case failure.

org.junit.ComparisonFailure: expected:<(Object [t]) ->> but was:<(Object [arg0]) ->>
	at org.eclipse.jdt.ls.core.internal.handlers.CompletionHandlerTest.testCompletion_Lambda(CompletionHandlerTest.java:3271)

@testforstephen testforstephen merged commit 3ba04d1 into eclipse-jdtls:master May 25, 2023
@testforstephen testforstephen deleted the jinbo_codeaction branch May 25, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants