Do not exit if client and server are the same process.

[mickaelistria]

No description provided.

[rgrunber]

• You probably want the same logic at https://github.com/eclipse/eclipse.jdt.ls/blob/fcfdd8f063ab79bcb0d7c69458e66266d2edcd1c/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/syntaxserver/SyntaxLanguageServer.java#L172 . The syntax server is the lightweight version. It's up to clients to decide whether to use it at all, so I suspect in eclipse.jdt.ls.client you don't really use it (currently). Would be good just to keep it consistent.

• Also, this is more of a warning. The same code exists in https://github.com/eclipse/eclipse.jdt.ls/blob/fcfdd8f063ab79bcb0d7c69458e66266d2edcd1c/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/ParentProcessWatcher.java#L63 . The parent process watcher makes sure the language server is killed, if for any reason the client/server interaction fails to do it. It is likely enabled by default if you haven't explicitly set the system property watchParentProcess to false. See https://github.com/eclipse/eclipse.jdt.ls/blob/fcfdd8f063ab79bcb0d7c69458e66266d2edcd1c/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/JavaLanguageServerPlugin.java#L372-L376 . So you can either disable the parent process watcher, or ensure you always set the parent process id to be the same as the LS. If not, you might still see Eclipse being killed.

[mickaelistria]

You probably want the same logic at

Actually, I don't care about the syntax server. But if you want, I can definitely make the same change there.

So you can either disable the parent process watcher, or ensure you always set the parent process id to be the same as the LS. If not, you might still see Eclipse being killed.

Thanks for the tip, I'll use the flag to disable it.

[rgrunber]

Just updated commit message. I think we can leave the syntax server alone for now.

[mickaelistria]

thank you!