Add java.configuration.maven.defaultMojoExecutionAction #2426
Conversation
snjeza
requested review from
gorkem,
fbricon,
rgrunber,
jdneo and
testforstephen
snjeza
force-pushed
the
issue-2899
branch
2 times, most recently
from
483f8d5 to
e73854e
Compare
| for (IProject project : ProjectUtils.getAllProjects()) { | ||
| if (ProjectUtils.isMavenProject(project)) { | ||
| JavaLanguageServerPlugin.getProjectsManager().updateProject(project, true); | ||
| } | ||
| } | ||
| } catch (CoreException e) { | ||
| JavaLanguageServerPlugin.logException("failed to set not covered Maven plugin execution severity", e); | ||
| } | ||
| } | ||
| String newMavenDefaultMavenExecutionAction = preferences.getMavenDefaultMojoExecutionAction(); | ||
| String oldMavenDefaultMavenExecutionAction = getMavenConfiguration().getDefaultMojoExecutionAction() == null ? null : getMavenConfiguration().getDefaultMojoExecutionAction().name(); | ||
| if (!Objects.equals(newMavenDefaultMavenExecutionAction, oldMavenDefaultMavenExecutionAction)) { | ||
| PluginExecutionAction action = PluginExecutionAction.valueOf(newMavenDefaultMavenExecutionAction == null ? "ignore" : newMavenDefaultMavenExecutionAction); | ||
| getMavenConfiguration().setDefaultMojoExecutionAction(action); | ||
| for (IProject project : ProjectUtils.getAllProjects()) { | ||
| if (ProjectUtils.isMavenProject(project)) { | ||
| JavaLanguageServerPlugin.getProjectsManager().updateProject(project, true); | ||
| } | ||
| } |
There was a problem hiding this comment.
please don't update the projects twice. First determine if severity or action changed, then trigger the update of maven projects
There was a problem hiding this comment.
I really wish the preference manager was decoupled from Maven (or other build tools).
Maybe we need a BuildPreferences interface and delegate build tool specific operations to specific implementations. But that's for another PR.
There was a problem hiding this comment.
actually a simple preference listener mechanism should help easily decouple all that
There was a problem hiding this comment.
please don't update the projects twice. First determine if severity or action changed, then trigger the update of maven projects
Fixed.
I really wish the preference manager was decoupled from Maven (or other build tools).
Maybe we need a BuildPreferences interface and delegate build tool specific operations to specific implementations. But that's for another PR.
Could you, please, create a new issue?
Signed-off-by: Snjezana Peco <snjezana.peco@redhat.com>
|
@fbricon I have updated the PR. |
|
Change seems to work well. I just noticed that by modifying : For example, if I set |
|
Related issues:
io.quarkus.platform:quarkus-maven-plugin:2.15.0.Final:generate-code-testsredhat-developer/vscode-java#2889Requires redhat-developer/vscode-java#2907
Signed-off-by: Snjezana Peco snjezana.peco@redhat.com