Create cleanup actions for some existing quick assists.

[rgrunber]

• Add final modifier where possible
• Convert switch statement to switch expression
• Use pattern matching for instanceof checks
• Convert anonymous function to lambda expression
• Add test cases, and set CleanUpsTest compliance to 19

Signed-off-by: Roland Grunberg rgrunber@redhat.com

[datho7561]

If I use

package org.acme;

import java.io.File;
import java.io.FileFilter;
import java.util.Arrays;

public class RolandsTest {
    public void test() {
        String PATH = "/this/is/some/path";
        String MESSAGE = """
                This is a message.\
                This message has multiple lines.\
                We can convert it to a text block""";

        final Object[] obj = Arrays.asList(PATH).toArray();
        if (obj[0] instanceof String) {
            String tmp = (String) obj[0];
            File f = new File(tmp);
            File[] filtered = f.listFiles(new FileFilter() {
                @Override
                public boolean accept(File path) {
                    return true;
                }
            });
        }
    }
};

with

"java.cleanup.actionsOnSave": [
  "addOverride",
  "stringConcatToTextBlock",
  "invertEquals",
  "addFinalModifier",
  "lambdaExpression",
],

I get an NPE

[rgrunber]

Thanks. It's reproducible in the tests as well. I forgot I changed the API of the cleanup retrieval to return null instead of an empty list when moving from LSP4J TextEdit -> Eclipse TextEdit.

Also need to update the original tests to compare content.

[rgrunber]

Also, if we ever need to implement a proper TextEdit for the cleanups, we could use https://github.com/google/diff-match-patch/blob/master/java/src/name/fraser/neil/plaintext/diff_match_patch.java#L1769 .

[datho7561]

Works very well!

[datho7561]

Looks good to me. Thanks, Roland!