Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix backslashes (\) in java.format.settings.url #1774

Merged
merged 1 commit into from
May 21, 2021

Conversation

snjeza
Copy link
Contributor

@snjeza snjeza commented May 19, 2021

Fixes redhat-developer/vscode-java#1944

Signed-off-by: Snjezana Peco snjezana.peco@redhat.com

Signed-off-by: Snjezana Peco <snjezana.peco@redhat.com>
Copy link
Contributor

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was able to test this out on Windows, and definitely resolves the issue (although it does log the failure). I guess it we can support '\' then we should try to do so.

@snjeza feel free to merge.

@snjeza snjeza merged commit 9741dfb into eclipse-jdtls:master May 21, 2021
@rgrunber rgrunber added this to the End June 2021 milestone Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changes on the profile have no effect if there are backslashes (\\) in the format.settings.url
2 participants