Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invisible project forgets source paths on classpath update #1647

Closed
rgrunber opened this issue Jan 18, 2021 · 0 comments · Fixed by #1710
Closed

Invisible project forgets source paths on classpath update #1647

rgrunber opened this issue Jan 18, 2021 · 0 comments · Fixed by #1710
Assignees

Comments

@rgrunber
Copy link
Contributor

  1. Set up the invisible project (include a jar in the lib/ folder)
  2. Create a source file that references a class from the jar and either hover over the type or go to the definition to trigger the source file resolution.
  3. Update the project classpath by adding a second jar to the lib folder

The type reference should now produce the same result as if it were simply a library with no corresponding sources. The first jar's source classpath should disappear likely due to a bug with the invisible project's classpath updating logic.

rgrunber added a commit to rgrunber/eclipse.jdt.ls that referenced this issue Mar 30, 2021
- Source detection should retrieve the source artifact from the local
  Maven repository if it exists
- Resolves eclipse-jdtls#1647
- Add to testDynamicSourceLookups testcase
- Move DependencyUtil into core bundle

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
rgrunber added a commit to rgrunber/eclipse.jdt.ls that referenced this issue Mar 30, 2021
- Source detection should retrieve the source artifact from the local
  Maven repository if it exists
- Resolves eclipse-jdtls#1647
- Add to testDynamicSourceLookups testcase
- Move DependencyUtil into core bundle

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
rgrunber added a commit to rgrunber/eclipse.jdt.ls that referenced this issue Apr 10, 2021
- Resolves eclipse-jdtls#1647
- Add to testDynamicSourceLookups testcase

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
fbricon pushed a commit that referenced this issue Apr 12, 2021
- Resolves #1647
- Add to testDynamicSourceLookups testcase

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
@fbricon fbricon added this to the Mid April 2021 milestone Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants