Add Assign statement to new variable/field code action

[snjeza]

Fixes redhat-developer/vscode-java#1208
Requires redhat-developer/vscode-java#1252

Signed-off-by: Snjezana Peco snjezana.peco@redhat.com

[snjeza]

Test failures are caused by #1318

[fbricon]

test this please

[fbricon]

It works well, but it doesn't show up as a refactoring. It has the quickassist kind instead.
I'd expect to see refactor.assign.variable and refactor.assign.field kinds instead, so that they could eventually be bound to shortcuts

[fbricon]

So Eclipse doesn't show it as a refactoring either (obviously since QuickAssistProcessor is coming from there), but there's a shortcut assigned nonetheless.

Not sure which kind we're supposed to use then, but most definitely something more precise than quickassist

[snjeza]

test this please

[snjeza]

@fbricon I have updated the PR.

[fbricon]

Could we automatically trigger the variable/field rename, after the code action has been applied, similar to 'extract to ...' methods? This requires extra code on the client side.

[snjeza]

@fbricon I have updated the PR.

[fbricon]

So, if I try the example from redhat-developer/vscode-java#1208:

session.createNativeQuery("sqlString").scroll();

when the cursor is on session (or when selecting the full expression), I get the "Assign statement" proposals when triggering quickfixes in vscode (ctrl+.), which is good, but not when the cursor is on createNativeQuery or scroll.
Whereas Eclipse IDE proposes those on all these locations.

[snjeza]

@fbricon I have updated the PR.

[fbricon]

Thanks @snjeza !