codeAction/resolve throws errors when your machine's processor count is too low.

[ethan-vanderheijden]

When I open the source actions menu, it creates three textDocument/codeAction requests. When I select "Organize Imports", it tries to resolve the second request through codeAction/resolve, but the JDTLS throws an error saying that it cannot find the request id.

I think the issue is here:

eclipse.jdt.ls/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/CodeActionHandler.java

Lines 80 to 81 in bb26c98

	public static final ResponseStore<Either<ChangeCorrectionProposalCore, CodeActionProposal>> codeActionStore
	= new ResponseStore<>(ForkJoinPool.commonPool().getParallelism());

My machine only has 2 processor cores, so ForkJoinPool.commonPool().getParallelism() returns 1, and only storing one CodeActionProposal isn't enough in many situations.

Can we make codeActionStore's max size configurable? Or set the size to Math.max(ForkJoinPool.commonPool().getParallelism(), 8)?

[rgrunber]

Good catch. Here's the commit that introduced it d87dbcb#diff-419f075b7b562e824b4f38f2b6be9714c669ba4e72785216d8352f9517448fdbR66 . The change was done as part of the introduction of resolve support for code actions.

@testforstephen I'm assuming the request cache was tied to the common pool's parallelism because it's assumed that's how many code action requests could run in parallel ? It doesn't look like this holds.