Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performing search operation are blocked until the build is done in vscode #2091

Open
gayanper opened this issue May 17, 2022 · 4 comments
Open

Comments

@gayanper
Copy link
Contributor

When opening a workspace, the project build is started. When the project is large it takes time to complete the build which is same in Eclipse as well. But in vscode the search operations such as reference and call hierarchy are blocked until the build is finished. In eclipse this works fine. As I remember a search operation is only blocked for indexing operations. It would be nice to support the same behavior as in Eclipse IDE from the LS as well so editors like VSCode can simulate the same behavior like Eclipse IDE.

@snjeza
Copy link
Contributor

snjeza commented May 17, 2022

When opening a workspace, the project build is started.

@gayanper it would happen only when starting your workspace the first time.
Could you provide a project sample?

@gayanper
Copy link
Contributor Author

Unfortunately the project is proprietary. But will try with for example jdt.core and see if i experience the same and get back

@testforstephen
Copy link
Contributor

This should be related with the timing of registering these capabilities. At the moment we delay the registration until the build job has finished. It makes sense to enable earlier if some features don't conflict with build job.

https://github.com/eclipse/eclipse.jdt.ls/blob/2130d70af2c39cbf7c6da825f89580456361608a/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/JDTLanguageServer.java#L270-L283

@rgrunber
Copy link
Contributor

rgrunber commented Feb 6, 2023

Is this really the case ? I just tried re-importing eclipse.jdt.ls into a fresh Eclipse workspace, and a call hierarchy search still seemed to block until the build was completed.

For what it's worth, with #2341, the time it takes for the index to load could be improved quite a bit. With that said, I agree that we should look into registering capabilities sooner if it allows users to take advantage of more functionality sooner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants