Skip to content

Commit 9d20b73

Browse files
committed
React to removal of 'is60orHigher' from JDT.
- JavaModelUtil.is50OrHigher has also been removed - Assume such expressions are always true as a lower compliance is no longer supported Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
1 parent 0eef634 commit 9d20b73

File tree

4 files changed

+2
-12
lines changed

4 files changed

+2
-12
lines changed

org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/contentassist/ParameterGuesser.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@ private PrimitiveType.Code getPrimitiveTypeCode(String type) {
212212
if (code != null) {
213213
return code;
214214
}
215-
if (fEnclosingElement != null && JavaModelUtil.is50OrHigher(fEnclosingElement.getJavaProject())) {
215+
if (fEnclosingElement != null) {
216216
if (code == PrimitiveType.SHORT) {
217217
if ("java.lang.Short".equals(type)) { //$NON-NLS-1$
218218
return code;

org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/corrections/QuickFixProcessor.java

+1-4
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@
4040
import org.eclipse.jdt.core.dom.ASTNode;
4141
import org.eclipse.jdt.core.manipulation.CUCorrectionProposalCore;
4242
import org.eclipse.jdt.core.manipulation.ChangeCorrectionProposalCore;
43-
import org.eclipse.jdt.internal.corext.util.JavaModelUtil;
4443
import org.eclipse.jdt.internal.ui.text.correction.IProposalRelevance;
4544
import org.eclipse.jdt.internal.ui.text.correction.UnInitializedFinalFieldBaseSubProcessor;
4645
import org.eclipse.jdt.internal.ui.text.correction.proposals.AddImportCorrectionProposalCore;
@@ -683,9 +682,7 @@ private void process(CodeActionParams params, IInvocationContext context, IProbl
683682
String str = problem.toString();
684683
System.out.println(str);
685684
}
686-
if (JavaModelUtil.is50OrHigher(context.getCompilationUnit().getJavaProject())) {
687-
SuppressWarningsSubProcessor.addSuppressWarningsProposals(context, problem, proposals);
688-
}
685+
SuppressWarningsSubProcessor.addSuppressWarningsProposals(context, problem, proposals);
689686
// ConfigureProblemSeveritySubProcessor.addConfigureProblemSeverityProposal(context,
690687
// problem, proposals);
691688
}

org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/GenerateToStringHandler.java

-6
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626
import org.eclipse.jdt.core.IJavaElement;
2727
import org.eclipse.jdt.core.IMember;
2828
import org.eclipse.jdt.core.IType;
29-
import org.eclipse.jdt.core.JavaCore;
3029
import org.eclipse.jdt.core.JavaModelException;
3130
import org.eclipse.jdt.core.dom.ASTNode;
3231
import org.eclipse.jdt.core.dom.CompilationUnit;
@@ -41,7 +40,6 @@
4140
import org.eclipse.jdt.internal.corext.codemanipulation.tostringgeneration.ToStringGenerationSettingsCore;
4241
import org.eclipse.jdt.internal.corext.codemanipulation.tostringgeneration.ToStringGenerationSettingsCore.CustomBuilderSettings;
4342
import org.eclipse.jdt.internal.corext.dom.ASTNodes;
44-
import org.eclipse.jdt.internal.corext.util.JavaModelUtil;
4543
import org.eclipse.jdt.ls.core.internal.JavaLanguageServerPlugin;
4644
import org.eclipse.jdt.ls.core.internal.corrections.DiagnosticsHelper;
4745
import org.eclipse.jdt.ls.core.internal.handlers.JdtDomModels.BindingComparator;
@@ -199,10 +197,6 @@ public static TextEdit generateToString(IType type, LspVariableBinding[] fields,
199197
settings.limitElements = preferences.getGenerateToStringLimitElements() > 0;
200198
settings.limitValue = Math.max(preferences.getGenerateToStringLimitElements(), 0);
201199
settings.customBuilderSettings = new CustomBuilderSettings();
202-
if (type.getCompilationUnit().getJavaProject() != null) {
203-
String version = type.getCompilationUnit().getJavaProject().getOption(JavaCore.COMPILER_SOURCE, true);
204-
settings.is60orHigher = !JavaModelUtil.isVersionLessThan(version, JavaCore.VERSION_1_6);
205-
}
206200

207201
return generateToString(type, fields, settings, insertPosition, monitor);
208202
}

org.eclipse.jdt.ls.tests/src/org/eclipse/jdt/ls/core/internal/handlers/GenerateToStringHandlerTest.java

-1
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,6 @@ public void testGenerateToString_customizedSettings() throws ValidateEditExcepti
218218
settings.limitElements = true;
219219
settings.limitValue = 10;
220220
settings.customBuilderSettings = new CustomBuilderSettings();
221-
settings.is60orHigher = true;
222221
generateToString(unit.findPrimaryType(), settings);
223222

224223
/* @formatter:off */

0 commit comments

Comments
 (0)