Dirty Indicator in Editor

[glsp-bot]

Currently the Editor does not recognize moving Edges as Changes to the file and does not update the dirty Indicator next to the filename.

My question would be where this indicator is set, so i can update that?

original thread by simongraband

[tortmayr]

Hi, the dirty state handling is GLSP has been updated recently (eclipse-glsp/glsp-server#32). Unfortunately the ecore-glsp project is currently still using the old GLSP plugins (we recently moved to Eclipse) so you cannot consume this update (yet). I think @camille-letavernier is handling the Eclipse-migration. Once this is done you can change the dirtystate from the server side with a SetDirtyStateAction.

[glsp-bot]

[simongraband]

I am currently working on updating the dirty Indicator, however i am unsure on what the best way, to update the indicator, is. I had a look at the PR, and it looks to me as i only need to update the isDirty() method of the modelIndex, since the Save/Undo/Redo handling is already done by the PR. What would be the best way to update the isDirty() method? I currently cannot find any handling via the basicCommandStack, like in the PR.

[tortmayr]

Hi, there is no need to update the isDirty() method directly. In theory the dirty state managment works out of the box with GLSP. Currently this is not the case for ecore glsp because you use customized action handlers that are missing some features.

[tortmayr]

In particular im talking about EcoreSaveModelActionHandler, EcoreUndoRedoOperationHandler and EcoreOperationActionHandler

[tortmayr]

On modelSave the modelState.saveIsDone() method has to be executed and a SetDirtyStateAction has to be returned to the client. This updates the dirty state automatically (https://github.com/eclipse-glsp/glsp-server/blob/07f0ca4205f430262747defb87926475d39e65db/plugins/org.eclipse.glsp.server/src/org/eclipse/glsp/server/actionhandler/SaveModelActionHandler.java#L57)

[tortmayr]

In addition, the handlers for operationAction and undoRedo have to return a SetDirtyStateAction as well

[tortmayr]

(https://github.com/eclipse-glsp/glsp-server/blob/07f0ca4205f430262747defb87926475d39e65db/plugins/org.eclipse.glsp.server/src/org/eclipse/glsp/server/actionhandler/UndoRedoActionHandler.java#L38)