Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not allow numTestsKeptInMemory to be set when headless #31167

Open
ryanthemanuel opened this issue Feb 25, 2025 · 0 comments
Open

Do not allow numTestsKeptInMemory to be set when headless #31167

ryanthemanuel opened this issue Feb 25, 2025 · 0 comments

Comments

@ryanthemanuel
Copy link
Collaborator

ryanthemanuel commented Feb 25, 2025

What would you like?

Today, we set numTestsKeptInMemory to 0 regardless when in run mode. However, there's still a hole where a user can use setupNodeEvents to set something other than 0 and the value sticks.

Why is this needed?

This prevents us from capturing snapshots properly when recording to protocol, so we should only allow non 0 values in situations where it's likely to be helpful (open mode or headed).

Other

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants