Typings (#699)

* Fixing

* Updaing helper code

* Home stretch for compiler fixes, just two left

* Touched up tests and Mocha Base reporter class type

* Adding some lint-related fixes for nightmarejs and appium

* Using value in Nightmare test instead of nodeValue

* Reverted Appium default config initialization location. Fixed waitFor methods in Nightmare to handle default parameter.

* Added the package-lock generated by npm 5

* Reverted using sec for parameter name for wait Helper methods

Author: Drew Diamantoukos

Diff for: .eslintrc

@@ -3,7 +3,8 @@
   "env": {
     "node": true,
     "mocha": true,
-    "es6": true
+    "es6": true,
+    "browser": true
   },
   "ecmaFeatures": {
     "jsx": true,

Diff for: gulpfile.js

@@ -11,6 +11,8 @@ var glob = require('glob');
 var guppy = require('git-guppy')(gulp);
 var gitmodified = require('gulp-gitmodified');
 var istanbul = require('gulp-istanbul');
+var ts = require("gulp-typescript");
+var tsProject = ts.createProject("tsconfig.json");
 
 function isFixed(file) {
 	// Has ESLint fixed the file contents?
@@ -46,6 +48,11 @@ gulp.task('static', function () {
     .pipe(gulp.dest('lib'));
 });
 
+gulp.task('type-check', function () {
+  return tsProject.src()
+    .pipe(tsProject());
+});
+
 gulp.task('pre-commit', ['static']);
 
 gulp.task('pre-test', function () {

Diff for: lib/assert/error.js

@@ -12,11 +12,10 @@ function AssertionFailedError(params, template) {
   // this.message = "AssertionFailedError";
   let stack = new Error().stack;
   // this.showDiff = true;
-  stack = stack.split("\n").filter((line) => {
+  stack = stack ? stack.split("\n").filter((line) => {
     // @todo cut assert things nicer
     return line.indexOf('lib/assert') < 0;
-  });
-  this.stack = stack.join("\n");
+  }).join("\n") : '';
   this.showDiff = true;
 
   this.actual = this.params.actual;

Diff for: lib/codecept.js

@@ -27,12 +27,12 @@ class Codecept {
   constructor(config, opts) {
     this.config = config;
     this.opts = opts;
-    this.testFiles = [];
+    this.testFiles = new Array();
   }
 
   /**
    * Initialize CodeceptJS at specific directory.
-   * If async initialization is required pass callbacke as second parameter.
+   * If async initialization is required, pass callback as second parameter.
    *
    * @param {*} dir
    * @param {*} callback
@@ -82,26 +82,26 @@ class Codecept {
    *
    * @param {*} done
    */
-  teardown(done) {
+  teardown(done = undefined) {
     runHook(this.config.teardown, done, 'teardown');
   }
 
   /**
    * Loads tests by pattern or by config.tests
    *
-   * @param {optional} pattern
+   * @param {string} [pattern]
    */
   loadTests(pattern) {
     pattern = pattern || this.config.tests;
-    glob.sync(fsPath.resolve(codecept_dir, pattern)).forEach((file) => {
+    glob.sync(fsPath.resolve(global.codecept_dir, pattern)).forEach((file) => {
       this.testFiles.push(fsPath.resolve(file));
     });
   }
 
   /**
    * Run a specific test or all loaded tests.
    *
-   * @param {optional} test
+   * @param {string} [test]
    */
   run(test) {
     let mocha = Container.mocha();

Diff for: lib/command/init.js

@@ -14,7 +14,7 @@ let mkdirp = require('mkdirp');
 let defaultConfig = {
   tests: "./*_test.js",
   timeout: 10000,
-  output: null,
+  output: '',
   helpers: {},
   include: {},
   bootstrap: false,
@@ -118,8 +118,11 @@ module.exports = function (initPath) {
     config.output = result.output;
 
     config.tests = result.tests;
-    // create a directory tests it is included in tests path
-    mkdirp.sync(path.join(testsPath, config.tests.match(/[^*.]+/)[0]));
+    // create a directory tests if it is included in tests path
+    let matchResults = config.tests.match(/[^*.]+/);
+    if (matchResults) {
+      mkdirp.sync(path.join(testsPath, matchResults[0]));
+    }
 
     // append file mask to the end of tests
     if (!config.tests.match(/\*(.*?)$/)) {

Diff for: lib/command/list.js

@@ -1,6 +1,5 @@
 'use strict';
 
-let urils = require('../utils');
 let getConfig = require('./utils').getConfig;
 let getTestRoot = require('./utils').getTestRoot;
 let Codecept = require('../codecept');
@@ -21,7 +20,7 @@ module.exports = function (path) {
 
     output.print('List of test actions: -- ');
     let helpers = container.helpers();
-    let suppportI = container.support('I');
+    let supportI = container.support('I');
     let actions = [];
     for (let name in helpers) {
       let helper = helpers[name];
@@ -31,11 +30,11 @@ module.exports = function (path) {
         output.print(` ${output.colors.grey(name)} I.${output.colors.bold(action)}(${params})`);
       });
     }
-    for (let name in suppportI) {
+    for (let name in supportI) {
       if (actions[name]) {
         continue;
       }
-      let actor = suppportI[name];
+      let actor = supportI[name];
       let params = getParamsToString(actor);
       output.print(` I.${output.colors.bold(name)}(${params})`);
     }

Diff for: lib/command/run-multiple.js

@@ -155,8 +155,8 @@ function replaceValue(obj, key, value) {
   if (obj[key]) obj[key] = value;
   if (typeof obj === "object" && obj !== null) {
     var children = Object.keys(obj);
-    for (i = 0; i < children.length; i++) {
-      replaceValue(obj[children[i]], key, value);
+    for (let childIndex = 0; childIndex < children.length; childIndex++) {
+      replaceValue(obj[children[childIndex]], key, value);
     }
   }
   return obj;

Diff for: lib/container.js

@@ -34,7 +34,7 @@ class Container {
    * Get all support objects or get support object by name
    *
    * @api
-   * @param {optional} name
+   * @param {string} [name]
    */
   static support(name) {
     if (!name) {
@@ -47,7 +47,7 @@ class Container {
    * Get all helpers or get a helper by name
    *
    * @api
-   * @param {optional} name
+   * @param {string} [name]
    */
   static helpers(name) {
     if (!name) {
@@ -104,10 +104,10 @@ function createHelpers(config) {
   let helperModule;
   for (let helperName in config) {
     try {
-      module = config[helperName].require
+      let moduleName = config[helperName].require
         ? path.resolve(global.codecept_dir, config[helperName].require) // custom helper
         : './helper/' + helperName; // built-in helper
-      let HelperClass = require(module);
+      let HelperClass = require(moduleName);
       if (HelperClass._checkRequirements) {
         let requirements = HelperClass._checkRequirements();
         if (requirements) {

Diff for: lib/data/table.js

@@ -7,7 +7,7 @@ class DataTable {
 
   constructor(array) {
     this.array = array;
-    this.rows = [];
+    this.rows = new Array();
   }
 
   add(array) {

Diff for: lib/helper.js

@@ -23,7 +23,7 @@ class Helper {
   }
 
   /**
-   * Abstract method to provide requried config options
+   * Abstract method to provide required config options
    */
   static _config() {