Skip to content

refactor: validate cloudevent version agnostic #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 11, 2020
Merged

refactor: validate cloudevent version agnostic #311

merged 1 commit into from
Aug 11, 2020

Conversation

grant
Copy link
Member

@grant grant commented Aug 11, 2020

Proposed Changes

  • Simplify CE validation

Description

@grant
refactor: validate cloudevent version agnostic
2b72453 
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
@grant grant requested a review from lance August 11, 2020 04:38
@grant grant self-assigned this Aug 11, 2020
lance
lance approved these changes Aug 11, 2020
View reviewed changes
Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lance
Copy link
Member

lance commented Aug 11, 2020

Looks good to me. But I don't understand how it "fixes" #273 really.

I'd expect the Binary/Structured Receiver to be really easy to setup. A developer shouldn't need to know about what mode the CloudEvent is in when receiving.

This PR doesn't really have any impact on the end user experience. So maybe you can clarify what you mean here.

lholmquist
lholmquist approved these changes Aug 11, 2020
View reviewed changes
Copy link
Contributor

@lholmquist lholmquist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

less code, less errors

but same question about how it relates to #273

@grant grant merged commit 8ac3eb0 into cloudevents:master Aug 11, 2020
@grant grant deleted the grant_refactor_validate branch August 11, 2020 15:09
@grant
Copy link
Member Author

grant commented Aug 11, 2020

It doesn't fix #273, it's just helping for future PRs that allow for #273 to be fixed. Fixing #273 directly is a little bit more complicated as it touches many areas of the SDK.

@lance lance mentioned this pull request Sep 9, 2020
Merged
lance pushed a commit that referenced this pull request Sep 11, 2020
@grant @lance
refactor: validate cloudevent version agnostic (#311)
3d2f01a 
Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
@lholmquist lholmquist mentioned this pull request Oct 26, 2020
Closed
@lholmquist lholmquist mentioned this pull request Dec 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance lance lance approved these changes

@lholmquist lholmquist lholmquist approved these changes

Assignees

@grant grant

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grant @lance @lholmquist