Skip to content

chore(actions): don't auto-close stale issues and pull requests #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

lance
Copy link
Member

@lance lance commented Jul 1, 2020

Open issues and pull requests should be closed by a human who has considered
the issue/pr and made a choice based on the content of the issue/pr and the
state of the repository.

What this means in practice is that some issues will stay open for a long
time, even if they are stale. They may be open because it really is something
that will be considered for future work. Periodic issue triage should be
done by the maintainers, and if an issue should be closed - for example,
the issue is no longer relevant - then a maintainer can close it.

Signed-off-by: Lance Ball lball@redhat.com

Open issues and pull requests should be closed by a human who has considered
the issue/pr and made a choice based on the content of the issue/pr and the
state of the repository.

What this means in practice is that some issues will stay open for a long
time, even if they are stale. They may be open because it really is something
that will be considered for future work. Periodic issue triage should be
done by the maintainers, and if an issue _should_ be closed - for example,
the issue is no longer relevant - then a maintainer can close it.

Signed-off-by: Lance Ball <lball@redhat.com>
@lance lance added the chore/actions Changes or additions to GitHub Workflow actions label Jul 1, 2020
@lance lance requested review from a team, danbev, lholmquist and helio-frota and removed request for a team July 1, 2020 18:31
Signed-off-by: Lance Ball <lball@redhat.com>
Copy link
Contributor

@lholmquist lholmquist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the fix that @helio-frota suggested LGTM

Signed-off-by: Lance Ball <lball@redhat.com>
@lance lance merged commit d65b013 into cloudevents:master Jul 2, 2020
@lance lance mentioned this pull request Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore/actions Changes or additions to GitHub Workflow actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants