Skip to content

Commit b99e6ea

Browse files
authored
lib: correct name of CONTENT_ENCODING constant (#168)
Signed-off-by: Daniel Bevenius <daniel.bevenius@gmail.com>
1 parent d836b06 commit b99e6ea

File tree

5 files changed

+9
-9
lines changed

5 files changed

+9
-9
lines changed

Diff for: lib/bindings/http/constants.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ module.exports = Object.freeze({
3232
ID: "ce-id",
3333
TIME: "ce-time",
3434
SCHEMA_URL: "ce-schemaurl",
35-
CONTENT_ENCONDING: "ce-datacontentencoding",
35+
CONTENT_ENCODING: "ce-datacontentencoding",
3636
SUBJECT: "ce-subject",
3737
EXTENSIONS_PREFIX: "ce-"
3838
},
@@ -43,7 +43,7 @@ module.exports = Object.freeze({
4343
ID: "id",
4444
TIME: "time",
4545
SCHEMA_URL: "schemaurl",
46-
CONTENT_ENCONDING: "datacontentencoding",
46+
CONTENT_ENCODING: "datacontentencoding",
4747
CONTENT_TYPE: "datacontenttype",
4848
SUBJECT: "subject",
4949
DATA: "data"

Diff for: lib/bindings/http/emitter_binary_0_3.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ headerByGetter.getDataContentType = {
1111
};
1212

1313
headerByGetter.getDataContentEncoding = {
14-
name: BINARY_HEADERS_03.CONTENT_ENCONDING,
14+
name: BINARY_HEADERS_03.CONTENT_ENCODING,
1515
parser: (v) => v
1616
};
1717

Diff for: lib/bindings/http/receiver_binary_0_3.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ setterByHeader[Constants.HEADER_CONTENT_TYPE] = {
6767
name: "dataContentType",
6868
parser: (v) => v
6969
};
70-
setterByHeader[Constants.BINARY_HEADERS_03.CONTENT_ENCONDING] = {
70+
setterByHeader[Constants.BINARY_HEADERS_03.CONTENT_ENCODING] = {
7171
name: "dataContentEncoding",
7272
parser: (v) => v
7373
};
@@ -82,7 +82,7 @@ function checkDecorator(payload, headers) {
8282
Object.keys(headers)
8383
.map((header) => header.toLocaleLowerCase("en-US"))
8484
.filter((header) =>
85-
header === Constants.BINARY_HEADERS_03.CONTENT_ENCONDING)
85+
header === Constants.BINARY_HEADERS_03.CONTENT_ENCODING)
8686
.filter((header) => !allowedEncodings.includes(headers[header]))
8787
.forEach((header) => {
8888
// TODO: using forEach here seems off

Diff for: test/bindings/http/unmarshaller_0_3_tests.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,7 @@ describe("HTTP Transport Binding Unmarshaller for CloudEvents v0.3", () => {
183183
[BINARY_HEADERS_03.TIME]: "2019-06-16T11:42:00Z",
184184
[BINARY_HEADERS_03.SCHEMA_URL]: "http://schema.registry/v1",
185185
[HEADER_CONTENT_TYPE]: "application/json",
186-
[BINARY_HEADERS_03.CONTENT_ENCONDING]: BINARY
186+
[BINARY_HEADERS_03.CONTENT_ENCODING]: BINARY
187187
};
188188

189189
expect(() => un.unmarshall(payload, attributes)).to
@@ -205,7 +205,7 @@ describe("HTTP Transport Binding Unmarshaller for CloudEvents v0.3", () => {
205205
[BINARY_HEADERS_03.TIME]: "2019-06-16T11:42:00Z",
206206
[BINARY_HEADERS_03.SCHEMA_URL]: "http://schema.registry/v1",
207207
[HEADER_CONTENT_TYPE]: "application/json",
208-
[BINARY_HEADERS_03.CONTENT_ENCONDING]: "base64"
208+
[BINARY_HEADERS_03.CONTENT_ENCODING]: "base64"
209209
};
210210

211211
const event = un.unmarshall(payload, attributes);

Diff for: test/constants_test.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ describe("Constants exposed by top level exports", () => {
9292
expect(BINARY_HEADERS_03.SCHEMA_URL).to.equal("ce-schemaurl");
9393
});
9494
it("Provides a CONTENT_ENCODING header", () => {
95-
expect(BINARY_HEADERS_03.CONTENT_ENCONDING).to.equal("ce-datacontentencoding");
95+
expect(BINARY_HEADERS_03.CONTENT_ENCODING).to.equal("ce-datacontentencoding");
9696
});
9797
it("Provides a SUBJECT header", () => {
9898
expect(BINARY_HEADERS_03.SUBJECT).to.equal("ce-subject");
@@ -121,7 +121,7 @@ describe("Constants exposed by top level exports", () => {
121121
expect(STRUCTURED_ATTRS_03.SCHEMA_URL).to.equal("schemaurl");
122122
});
123123
it("Provides a CONTENT_ENCODING attribute", () => {
124-
expect(STRUCTURED_ATTRS_03.CONTENT_ENCONDING).to.equal("datacontentencoding");
124+
expect(STRUCTURED_ATTRS_03.CONTENT_ENCODING).to.equal("datacontentencoding");
125125
});
126126
it("Provides a SUBJECT attribute", () => {
127127
expect(STRUCTURED_ATTRS_03.SUBJECT).to.equal("subject");

0 commit comments

Comments
 (0)