fix(phpstan): reviewed codebase and dropped treatPhpDocTypesAsCertain: false setting

Author: KaiSchwarz-cnic

.github/linters/phpstan.neon

@@ -1,8 +1,5 @@
 parameters:
     level: 8
-    treatPhpDocTypesAsCertain: false
-    #phpVersion: 80100
-    #treatPhpDocTypesAsCertain: false
     fileExtensions:
         - php
         - module

src/CNR/Client.php

@@ -95,7 +95,7 @@ public function request($cmd = [])
         ] + $this->curlopts);
 
         // which is by default tested for by phpStan
-        /** @var string $r */
+        /** @var string|false $r */
         $r = curl_exec($curl);
         $error = null;
         if ($r === false) {

src/HEXONET/Client.php

@@ -460,7 +460,7 @@ public function request($cmd)
         ] + $this->curlopts);
 
         // which is by default tested for by phpStan
-        /** @var string $r */
+        /** @var string|false $r */
         $r = curl_exec($curl);
         $error = null;
         if ($r === false) {

src/HEXONET/ResponseTranslator.php

@@ -75,8 +75,7 @@ public static function translate($raw, $cmd, $ph = [])
         // Missing CODE or DESCRIPTION in API Response
         if (
             (
-                $newraw === null
-                || !preg_match("/description[\s]*=/i", $newraw) // missing description
+                !preg_match("/description[\s]*=/i", $newraw) // missing description
                 || preg_match("/description[\s]*=\r\n/i", $newraw) // empty description
                 || !preg_match("/code[\s]*=/i", $newraw) // missing code
             )
@@ -156,15 +155,8 @@ protected static function findMatch($regex, &$newraw, $val, $cmd, $ph)
         // Generic replacing of placeholder vars
         if (preg_match("/\{[^}]+\}/", $newraw)) {
             foreach ($ph as $key => $val) {
-                if ($newraw === null) {
-                    continue;
-                }
                 $newraw = preg_replace("/\{" . preg_quote($key, "/") . "\}/", $val, $newraw) ?? $newraw;
             }
-            if ($newraw === null) {
-                return $return;
-            }
-
             $newraw = preg_replace("/\{[^}]+\}/", "", $newraw) ?? $newraw;
             $return = true;
         }