add update function in ManifoldProblem

correct tests

Author: rveltz

README.md

@@ -26,12 +26,12 @@ $$F:\mathbb R^{n} \to \mathbb R^m. $$
 This package requires Julia >= v1.3.0
 
 To install it, please run
-
-`] add MultiParamContinuation`
+ 
+`] add https://github.com/bifurcationkit/MultiParamContinuation.jl`
 
 To install the bleeding edge version, please run
 
-`] add MultiParamContinuation#master`
+`] add https://github.com/bifurcationkit/MultiParamContinuation.jl#master`
 
 ## 📚 Support and citation
 If you use `BifurcationKit.jl` in your work, we ask that you cite the following paper on [HAL-Inria](https://hal.archives-ouvertes.fr/hal-02902346) with *bibtex* entry [CITATION.bib](https://github.com/bifurcationkit/BifurcationKit.jl/blob/master/CITATION.bib). Open source development as part of academic research strongly depends on this. Please also consider starring this repository if you like our work, this will help us to secure funding in the future.

src/problem.jl

@@ -1,5 +1,7 @@
 abstract type AbstractManifoldProblem end
 
+update_default(args...; kwargs...) = true
+
 for op in (:ManifoldProblem, :ManifoldProblemBK)
     @eval begin
     """
@@ -27,7 +29,7 @@ for op in (:ManifoldProblem, :ManifoldProblemBK)
                     )
     ```
     """
-    struct $op{Tu <: AbstractVector, Tp, TVF, Trec, Tproj, Ttangent, Tradius, Tevent, Tfinalize, Tbb, Tpc} <: AbstractManifoldProblem
+    struct $op{Tu <: AbstractVector, Tp, TVF, Trec, Tproj, Ttangent, Tradius, Tevent, Tfinalize, Tbb, Tpc, Tupdate} <: AbstractManifoldProblem
         "[Internal] input space dimension"
         n::Int
         "[Internal] output space dimension"
@@ -54,14 +56,16 @@ for op in (:ManifoldProblem, :ManifoldProblemBK)
         project_for_tree::Tbb
         "[Internal] constrained problem for projecting on manifold"
         prob_cons::Tpc
-
+        "Function used to update the problem after each continuation step. The signature is `update_problem!(prob, ::Atlas)`"
+        update!::Tupdate
     end
 
     Base.size(prob::$op) = (prob.n, prob.m)
     @inline Base.eltype(prob::$op{Tu}) where Tu = eltype(Tu)
     @inline _has_projection(::$op{Tu, Tp, TVF, Trec, Tproj}) where {Tu, Tp, TVF, Trec, Tproj} = ~(Tproj == Nothing)
     @inline _has_tangent_computation(::$op{Tu, Tp, TVF, Trec, Tproj, Ttangent}) where {Tu, Tp, TVF, Trec, Tproj, Ttangent} = ~(Ttangent == Nothing)
     @inline _has_event(::$op{Tu, Tp, TVF, Trec, Tproj, Ttangent, Tradius, Tevent}) where {Tu, Tp, TVF, Trec, Tproj, Ttangent, Tradius, Tevent} = ~(Tevent == Nothing)
+    @inline update_problem!(prob::$op, args...; kwargs...) = prob.update!(args...; kwargs...)
 
     function $op(F, u0, par;
                     m = length(F(u0, par)),
@@ -73,7 +77,8 @@ for op in (:ManifoldProblem, :ManifoldProblemBK)
                     event_function = event_default,
                     finalize_solution = finalize_default,
                     project_for_tree = project_for_tree_default,
-                    prob_cons = nothing
+                    prob_cons = nothing,
+                    update! = update_default
                     )
         n = length(u0)
         dim = n-m
@@ -92,7 +97,8 @@ for op in (:ManifoldProblem, :ManifoldProblemBK)
             event_function,
             finalize_solution,
             project_for_tree,
-            prob_cons)
+            prob_cons,
+            update!)
         end
     end
 end

test/4d.jl

@@ -10,7 +10,7 @@ end
 
 prob = ManifoldProblem(F, [0.2,0.2,-0.,0], nothing;
             finalize_solution = ProductSpace([-5,-5,-1,-1],[5,5,1,1]),
-            recordFromSolution = (u,p) -> [u[3],u[4],u[1]/2+u[2]/2]
+            record_from_solution = (u,p;k...) -> [u[3],u[4],u[1]/2+u[2]/2]
 )
 
 S = continuation(prob,