fix(logs): fix infinite retention for jsii users #3250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The retention period was still accepting the value `Infinity` for "infinite retention", even though the property has been changed to an enum instead of `number`. Even though this apparently works for TypeScript customers, jsii customers will not be able to pass in a number where an enum value is expected, and so won't be able to configure infinite retention. Add an `INFINITE` value to the enum.
eladb
approved these changes
Jul 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The retention period was still accepting the value
Infinityfor"infinite retention", even though the property has been changed to an
enum instead of
number.Even though this apparently works for TypeScript customers, jsii
customers will not be able to pass in a number where an enum value
is expected, and so won't be able to configure infinite retention.
Add an
INFINITEvalue to the enum.Please read the contribution guidelines and follow the pull-request checklist.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license