Skip to content

References to autonumeric need to be updated #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kalle-kilpi-midaxo opened this issue Feb 2, 2021 · 9 comments
Open

References to autonumeric need to be updated #55

kalle-kilpi-midaxo opened this issue Feb 2, 2021 · 9 comments

Comments

@kalle-kilpi-midaxo
Copy link

Hello,

This component has great potential but using it is very inconvenient as it uses the outdated AutoNumeric case instead of the current lower case autonumeric naming convention. This forces complicated webpack configs as a workaround. Would it be possible to fix this issue?

Just doing a simple replace all "AutoNumeric" to "autonumeric" in the source JS file seems to fix the problem.

Best,
Kal

@kalle-kilpi-midaxo
Copy link
Author

For those who need the alias workaround, put this in the vue.config.js file:

module.exports = {
  lintOnSave: false,
  configureWebpack: {
    resolve: {
      alias: {
        AutoNumeric: "autonumeric"
      }
    }
  }
};

@arthurnassar
Copy link

@AlexandreBonneau can I pick up this issue please? I have a big project to maintain that has failing pipelines due to this issue

@xuhdev
Copy link

xuhdev commented Apr 30, 2024

@arthurnassar You may not have noticed it but the author has thumbed up your comment :)

@arthurnassar
Copy link

arthurnassar commented Apr 30, 2024

@xuhdev yeah... I actually have something kinda ready but I'm having a difficult time on creating a branch to push it ...
image

Am I doing something wrong?

@AlexandreBonneau
Copy link
Member

You should fork this repo, push your changes to your own fork, then from github, create a pull request from your repo to this one

@arthurnassar
Copy link

Aaah ok ok ... thanks, its my first contribution so I was not familiar with the flow

@arthurnassar
Copy link

Well... I tried a lot, and none if my attempts worked. Only changing references wouldn't be enough because of the backwards compatibility with the CDN right? anyone has any ideas that could help or at least give a light on this? Would really like to turn this library compatible with both

@AlexandreBonneau
Copy link
Member

What do you mean by 'backwards compatibility with the CDN'?
What errors are you seeing, what did you try?

@arthurnassar
Copy link

Well by backwards compatibility I was meaning keep the lib working with both the CDN or the autonumeric on node_modules approach...
What I tried was to introduce a shim that would dinamically import the autonumeric either from the Window or from node_modules based on which of those were available...

Soon as I have some time I will post a detailed info of everything that I tried with the errors that I ran into.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants