Skip to content
This repository was archived by the owner on Sep 21, 2018. It is now read-only.

Update tools dependencies #535

Closed
analogrelay opened this issue May 3, 2016 · 8 comments
Closed

Update tools dependencies #535

analogrelay opened this issue May 3, 2016 · 8 comments

Comments

@analogrelay
Copy link
Contributor

analogrelay commented May 3, 2016

In the project.json file, remove the existing entries for Microsoft.Extensions.CodeGenerators.Mvc and Microsoft.EntityFrameworkCore.Commands and replace them with:

    "Microsoft.EntityFrameworkCore.Tools": {
        "version": "1.0.0-rc2-20634",
        "type": "build"
    },
    "Microsoft.Extensions.CodeGenerators.Mvc": {
        "version": "1.0.0-rc2-20634",
        "type": "build"
    },

Note:

  • Microsoft.EntityFrameworkCore.Commands has been renamed to Microsoft.EntityFrameworkCore.Tools (/cc @natemcmaster)
  • The type of both dependencies has changed to build.

Changing the types of these dependencies reduces the publish output size significantly.

Also, the tools have been renamed, see the project.json snippet below

The new dependencies and tools sections would look as follows (indentation is a bit off in my example):

  "dependencies": {
    "Microsoft.NETCore.App": {
      "version": "1.0.0-rc2-3002426",
      "type": "platform"
    },
    "Microsoft.Extensions.CodeGeneration.Tools": {
      "version": "1.0.0-rc2-20634",
      "type": "build"
    },
    "Microsoft.AspNetCore.Razor.Tools": {
      "version": "1.0.0-rc2-20634",
      "type": "build"
    },
    "Microsoft.EntityFrameworkCore.Tools": {
        "version": "1.0.0-rc2-20634",
        "type": "build"
    },
    "Microsoft.Extensions.CodeGenerators.Mvc": {
        "version": "1.0.0-rc2-20634",
        "type": "build"
    },

    "Microsoft.AspNetCore.Authentication.Cookies": "1.0.0-rc2-20634",
    "Microsoft.AspNetCore.Diagnostics": "1.0.0-rc2-20634",
    "Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore": "1.0.0-rc2-20634",
    "Microsoft.AspNetCore.Identity.EntityFrameworkCore": "1.0.0-rc2-20634",
    "Microsoft.AspNetCore.Mvc": "1.0.0-rc2-20634",
    "Microsoft.AspNetCore.Server.IISIntegration": "1.0.0-rc2-20634",
    "Microsoft.AspNetCore.Server.Kestrel": "1.0.0-rc2-20634",
    "Microsoft.AspNetCore.StaticFiles": "1.0.0-rc2-20634",
    "Microsoft.EntityFrameworkCore.SqlServer": "1.0.0-rc2-20634",
    "Microsoft.Extensions.Configuration.Json": "1.0.0-rc2-20634",
    "Microsoft.Extensions.Configuration.UserSecrets": "1.0.0-rc2-20634",
    "Microsoft.Extensions.Logging": "1.0.0-rc2-20634",
    "Microsoft.Extensions.Logging.Console": "1.0.0-rc2-20634",
    "Microsoft.Extensions.Logging.Debug": "1.0.0-rc2-20634",
    "Microsoft.VisualStudio.Web.BrowserLink.Loader": "14.0.0-rc2-20634"
  },

  "tools": {
    "Microsoft.Extensions.CodeGeneration.Tools": {
      "version": "1.0.0-rc2-20634",
      "imports": [
        "portable-net45+win8+dnxcore50",
        "portable-net45+win8"
      ]
    },
    "Microsoft.EntityFrameworkCore.Tools": {
      "version": "1.0.0-rc2-20634",
      "imports": "portable-net45+win8+dnxcore50"
    },
    "Microsoft.AspNetCore.Razor.Tools": {
      "version": "1.0.0-rc2-20634",
      "imports": "portable-net45+win8+dnxcore50"
    },
    "Microsoft.AspNetCore.Server.IISIntegration.Tools": {
      "version": "1.0.0-rc2-20634",
      "imports": "portable-net45+win8+dnxcore50"
    },
    "Microsoft.Extensions.SecretManager.Tools": {
      "version": "1.0.0-rc2-20634",
      "imports": "portable-net45+win8+dnxcore50"
    }
  },

/cc @DamianEdwards @prafullbhosale @natemcmaster

@natemcmaster
Copy link
Contributor

Btw, all those "dotnet-*" packages have been renamed. "dotnet-ef" was merged into Ms.EfCore.Tools.

@analogrelay analogrelay changed the title Update "CodeGenerators.MVC" and "EF.Commands" dependencies Update tools dependencies May 3, 2016
@phenning
Copy link
Contributor

phenning commented May 3, 2016

#534 has most of this information. Also, we've already decided to keep the tools sorted with the rest of the packages.

@analogrelay
Copy link
Contributor Author

Ok, as long as we've got both the tools rename and the "type:build" changed captured somewhere, we're good :).

@analogrelay analogrelay added this to the 1.0.0-rc2 milestone May 3, 2016
@rustd
Copy link
Contributor

rustd commented May 4, 2016

So there is no work remaining. Closing this out. @anurse feel free to open this if there is anything remaining.

@rustd rustd closed this as completed May 4, 2016
@analogrelay analogrelay reopened this May 4, 2016
@analogrelay
Copy link
Contributor Author

No, there's still work to do. The changes to convert the dependencies referenced above to be type: build have not been done yet.

@rustd
Copy link
Contributor

rustd commented May 4, 2016

Thanks! @phenning assigning to you.

@phenning
Copy link
Contributor

phenning commented May 4, 2016

Committed now

@phenning phenning closed this as completed May 4, 2016
@phenning
Copy link
Contributor

phenning commented May 4, 2016

aa31cb9

@phenning phenning removed their assignment May 4, 2016
@rustd rustd added 3 - Done bug and removed bug labels May 14, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants