Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Bug fix and refactoring of the Indexfile in tiered storage #7222

Closed
3 tasks done
lizhimins opened this issue Aug 22, 2023 · 0 comments · Fixed by #7224
Closed
3 tasks done

[Bug] Bug fix and refactoring of the Indexfile in tiered storage #7222

lizhimins opened this issue Aug 22, 2023 · 0 comments · Fixed by #7224

Comments

@lizhimins
Copy link
Member

lizhimins commented Aug 22, 2023

Before Creating the Bug Report

  • I found a bug, not just asking a question, which should be created in GitHub Discussions.
  • I have searched the GitHub Issues and GitHub Discussions of this repository and believe that this is not a duplicate.
  • I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ.

Runtime platform environment

Linux 4.19

RocketMQ version

latest version in develop branch

JDK Version

JDK11

Describe the Bug

The design logic of IndexFile in the current tiered storage system is confusion and there are some bugs, such as:

  • If the file that has been compacted is not successfully uploaded or still uploading, and the broker is restarted or crashes, the "current file" will not be initialized properly, resulting in the content of the file not being initialized to -1.
  • There are resource release issues, and the logic of resource release when compacting fails has not been considered.
  • The current design affects the main process of sending and receiving messages for building cq.
  • The current implementation of lock usage is incorrect.

Steps to Reproduce

None

What Did You Expect to See?

Resource not delete normally.

What Did You See Instead?

None

Additional Context

I will submit a bugfix for the current implementation and fix the ignored test cases. In the future, I hope to refactor the implementation of this IndexFile section.

@lizhimins lizhimins changed the title [Bug] Temporary fix index file bug in tiered storage module [Bug] Bug fix and refactoring of the Indexfile in tiered storage Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant