Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magit-todos-section-map hides the "j" keybinding expected in the status buffer #143

Closed
ghost opened this issue Mar 17, 2023 · 1 comment · Fixed by #169
Closed

magit-todos-section-map hides the "j" keybinding expected in the status buffer #143

ghost opened this issue Mar 17, 2023 · 1 comment · Fixed by #169
Assignees
Labels
bug Something isn't working
Milestone

Comments

@ghost
Copy link

ghost commented Mar 17, 2023

Hello,

I found that when using the jump command anywhere in the magit-status buffer, the transient menu was displayed as expected with the "T" and "l" options properly added after ed4f5c4.

image

However inside the todo section I don't get a transient menu when pressing "j" and only have "T" and "l" available as options :

image

The following patch seems to fix the issue :

image

---
 magit-todos.el | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/magit-todos.el b/magit-todos.el
index 0823ac9..158ff16 100644
--- a/magit-todos.el
+++ b/magit-todos.el
@@ -119,8 +119,7 @@ magit-status buffer.")
 
 (defvar magit-todos-section-map
   (let ((map (make-sparse-keymap)))
-    (define-key map "jT" #'magit-todos-jump-to-todos)
-    (define-key map "jl" #'magit-todos-list)
+    (set-keymap-parent map magit-status-mode-map)
     (define-key map "b" #'magit-todos-branch-list-toggle)
     (define-key map "B" #'magit-todos-branch-list-set-commit)
     (define-key map [remap magit-visit-thing] #'magit-todos-list)

base-commit: 7724259a008144b8cfc6cacdae3e764f207a03e7
-- 

EDIT: I should have mentioned I'm running emacs 30 and magit-todos version 1.6 (from melpa).

@alphapapa
Copy link
Owner

Thanks, I noticed this but hadn't gotten around to investigating.

@alphapapa alphapapa self-assigned this Mar 19, 2023
@alphapapa alphapapa added the bug Something isn't working label Mar 19, 2023
@alphapapa alphapapa added this to the 1.6.1 milestone Mar 19, 2023
@alphapapa alphapapa modified the milestones: 1.6.1, 1.7.1 Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant