Web Auth workflow creates ephemeral nodes unless tsdproxy.ephemeral explicitly set to false

[dkaser]

Describe the bug
When using the web auth workflow, containers are added as ephemeral nodes if tsdproxy.ephemeral is not set. Explicitly setting tsdproxy.ephemeral to false creates a persistent node.

Expected behavior
Behavior should follow documentation, which suggests that ephemeral nodes will only be created if the label is created and set to true.

Send config
Default config, no changes.

Logs
https://gist.github.com/dkaser/446eb81615ebe3bc09517a02418a2c49

Additional context
I am the maintainer of the TSDProxy template for Unraid. Multiple users have reported this behavior.

[almeidapaulopt]

when I started tsdproxy I made it to me, and it seemed to me that make more sense default it to true. Now, as a more users use the app, I agree that it should default the same as the tailscale default.
As this is a kind of "breaking change" (yes it won't break but will change expected behavior to actual users) , we need to find when this should be done.
but maybe in next version as it will have significant changes. see v1.5.0

thank you to bring this subject.

[dkaser]

I don't know that you need to make a breaking change for this -- clarification in the docs would be enough. As written, it makes it sound like the default is non-ephemeral, which creates confusion.

[almeidapaulopt]

can you identify where in the docs it makes that confusion?

[dkaser]

https://almeidapaulopt.github.io/tsdproxy/docs/docker/

If you want to use an ephemeral container, you can define it with the label tsdproxy.ephemeral.

This should say something more like "If you do not want to use an ephemeral container, you can make the machine persistent by setting tsdproxy.ephemeral to false.", then making the example match.