Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date store not synced properly when using a selector #160

Open
eEQK opened this issue Jan 19, 2025 · 1 comment · May be fixed by #164
Open

Date store not synced properly when using a selector #160

eEQK opened this issue Jan 19, 2025 · 1 comment · May be fixed by #164

Comments

@eEQK
Copy link

eEQK commented Jan 19, 2025

Describe the bug

given this store:

import { Store } from '@tanstack/react-store';

export const RootState = new Store({
    selectedDay: new Date(),
});

a is refreshed but b is not

export function DatePicker() {
  const a = useStore(RootState);
  const b = useStore(RootState, (s) => s.selectedDay);
  // ...
}

@thazlett16 said on discord:

I'm guessing this has to do with the shallow compare:
https://github.com/TanStack/store/blob/main/packages/react-store/src/index.ts#L34

I know in Redux they generally recommend storing dates in a serializeable format like the string form (RFC 3339, ISO 8601 etc)

Steps to Reproduce the Bug or Issue

example here: https://stackblitz.com/edit/tanstack-store-thn7c7az?file=src%2Findex.tsx

Expected behavior

both a and b should refresh (unless dates are not supposed to be supported)

@illodev
Copy link

illodev commented Jan 31, 2025

I’m experiencing the same issue with dates.

@SashaZel SashaZel linked a pull request Feb 4, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants