Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't update properties on object with update callback #86

Closed
wants to merge 1 commit into from

Conversation

eryx67
Copy link

@eryx67 eryx67 commented Jun 27, 2012

Probably, you haven't try to update object properties if update callback exists, especially
when some of parents are arrays and you can't set mappings for nested objects
(fullPropertyName has indexes in it, for example `[3].children[5].children[0].id').

@sagacity
Copy link
Collaborator

Thanks, can you also add a unit test to demonstrate the issue? (should be failing before merge, passing after merge)

@smrq
Copy link

smrq commented Aug 14, 2012

Unit test for this issue (I think it's the same one, the proposed patch causes the test to pass)

Failing w/out patch: http://jsfiddle.net/smrKyu/ndwfz/6/
Passing w/ patch: http://jsfiddle.net/smrKyu/ndwfz/

In CoffeeScript because it's a simplified view of the issue in my Coffee codebase.

@sagacity
Copy link
Collaborator

Thanks! I'll take a look asap.

@sagacity sagacity closed this in 20ccea6 Aug 20, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants