Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Icon] Update Font Awesome to 4.7.0 #4892

Closed
PhilipDavis opened this issue Jan 6, 2017 · 8 comments
Closed

[Icon] Update Font Awesome to 4.7.0 #4892

PhilipDavis opened this issue Jan 6, 2017 · 8 comments

Comments

@PhilipDavis
Copy link

PhilipDavis commented Jan 6, 2017

As a result, a few icons are missing (e.g. 'mouse pointer', 'delete calendar')

@PhilipDavis PhilipDavis changed the title [Icon] semantic-ui-icon 2.2.3 npm package ships with Font Awesome 4.2.0 [Icon] semantic-ui-icon 2.2.3 npm package ships with Font Awesome 4.2.0, not 4.5.6 Jan 7, 2017
@loris
Copy link

loris commented Jan 11, 2017

+1

@richardtallent
Copy link

richardtallent commented Feb 5, 2017

The current version of SUI is 2.2.7. I don't know what it comes with but I would guess 4.5+. 4.7.0 is the latest. I added FA manually to my pages so I'd have the latest rather than relying on SUI's bundled version. For a few icons, this meant adding my own i.blah.icon CSS classes to support a glyph not yet officially given an SUI class. (Pro tip: FA's CDN and font loading code is pretty slow, I have fewer browsers to support, so I just hosted the WOFF2 version myself and referenced it directly.)

I suspect I'll need to do the same when 5.0 is released, so it's a good habit to have already. (There's also a good chance FA will support ligatures (e.g., <i class="icon">facebook</i>), in which case I'd likely move away from specifying the icon using a CSS class anyway.)

@awgv awgv changed the title [Icon] semantic-ui-icon 2.2.3 npm package ships with Font Awesome 4.2.0, not 4.5.6 [Icon] Update Font Awesome to 4.7.0 (or 5.0 when it’s released) Feb 9, 2017
@awgv awgv changed the title [Icon] Update Font Awesome to 4.7.0 (or 5.0 when it’s released) [Icon] Update Font Awesome to 4.7.0 Feb 9, 2017
@awgv
Copy link
Member

awgv commented Feb 9, 2017

Closing the issue, because Font Awesome was already updated to 4.7 with #4766, and will soon be released along other changes with 2.2.8.

@awgv awgv closed this as completed Feb 9, 2017
@awgv awgv removed the Enhancement label Feb 9, 2017
@PhilipDavis
Copy link
Author

@Banandrew Thanks for addressing this issue! Are you saying that semantic-ui-icon will also be updated to Font Awesome 4.7? I am not using the full Semantic UI package.

@awgv
Copy link
Member

awgv commented Feb 9, 2017

@PhilipDavis Do you mean https://github.com/Semantic-Org/UI-Icon? It should, I think the robot automatically updates those, though, it delayed the 2.2.7 for some reason—hopefully, it won’t happen again. Since you’re not using the full SUI package, did you know you could remove components from your Gulp pipeline by modifying semantic.json file?

@PhilipDavis
Copy link
Author

@Banandrew Hmm... I have neither a Gulp pipeline nor a semantic.json... I've been doing npm install --save semantic-ui-icon (and other select Semantic UI packages).

@awgv
Copy link
Member

awgv commented Feb 10, 2017

@PhilipDavis I thought it was something you might want to know; If you follow the default installation process with npm install semantic-ui --save that will install everything the framework has to offer to node_modules, you can use the default build tools to build production-ready CSS/JS from the source (basically cd into the folder where the framework was installed, and run gulp build). If you follow that route, you don’t have to rely on semantic-ui-icon to be updated, you just modify semantic.json by removing components that you don’t need from components array—when you do that, production files are built without those components, so, say, if you only need icons, it will only put semantic-ui-icon in your semantic.min.css.

@PhilipDavis
Copy link
Author

@Banandrew awesome, very good to know. Thanks for the tip! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants